getAddrInfo: raise exception if no AddrInfo returned #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POSIX[1] requires getaddrinfo(3) to return at least one addrinfo: > Upon successful return of getaddrinfo(), the location to which res > points shall refer to a linked list of addrinfo structures, each of > which shall specify a socket address and information for use in > creating a socket with which to use that socket address. The list > shall include at least one addrinfo structure. This behaviour is also specified by the manpages for Linux[2], OpenBSD[3], FreeBSD[4], NetBSD[5] and macOS[6], and most example code just calls `head` (or equivalent) on the returned list anyway. It would have been nice to return `NonEmpty` here, but that was vetoed for backwards-compatibility reasons. [1]: http://pubs.opengroup.org/onlinepubs/9699919799/functions/getaddrinfo.html [2]: https://linux.die.net/man/3/getaddrinfo [3]: https://man.openbsd.org/getaddrinfo.3 [4]: http://nixdoc.net/man-pages/FreeBSD/man4/man3/getaddrinfo.3.html [5]: http://nixdoc.net/man-pages/NetBSD/man3/getaddrinfo.3.html [6]: https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/getaddrinfo.3.html
|
@eborden Would you suggest what kind of exception is proper for this case? |
|
@eborden In general, I like this PR. We should check the type of exception. |
|
@kazu-yamamoto |
eborden
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407.
POSIX1 requires getaddrinfo(3) to return at least one addrinfo:
This behaviour is also specified by the manpages for Linux2,
OpenBSD3, FreeBSD4, NetBSD5 and macOS6, and most example code
just calls
head(or equivalent) on the returned list anyway.It would have been nice to return
NonEmptyhere, but that was vetoedfor backwards-compatibility reasons.