Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackage shows non-public, internal libraries #1346

Open
phadej opened this issue Nov 23, 2024 · 2 comments
Open

Hackage shows non-public, internal libraries #1346

phadej opened this issue Nov 23, 2024 · 2 comments

Comments

@phadej
Copy link
Contributor

phadej commented Nov 23, 2024

This is wrong, please don't.

image

@nikita-volkov
Copy link

I second that and want to expand. There seems to be two problems currently.

  1. If the visibility setting is not specified for an internal library, the docs for it are rendered as if it's public. However the Cabal docs state that internal libraries are private by default. See "attoparsec" for example.

  2. If visibility is explicitly set to private the docs don't get rendered, but the contents of the internal library still get listed at the landing page of the package. See "hasql" for example.

I believe that in both cases Hackage should just ignore the internal packages and neither list or generate docs for them.

@gbaz
Copy link
Contributor

gbaz commented Dec 3, 2024

This feature was introduced by @414owen in #1279 -- maybe they'd be open to a followup PR? Patches from others also welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants