Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only notify about dependencies that bumped to next major version #1311

Open
andreasabel opened this issue May 15, 2024 · 2 comments
Open

Only notify about dependencies that bumped to next major version #1311

andreasabel opened this issue May 15, 2024 · 2 comments
Labels
component: notifications Abount notifications sent by Hackage re: notifications Concerning notifications sent to Hackage users

Comments

@andreasabel
Copy link
Member

I am getting notifications about bumping to base-4.20 when the package says base < 4.13 meaning it clearly is abandoned.

I'd like to get notifications only when my package has been up-to-date before. So, e.g. when it says base < 4.20 and then base is released with 4.20 or 5.x or maybe even 4.21 in case 4.20 is deprecated or does not exist.

@andreasabel andreasabel added re: notifications Concerning notifications sent to Hackage users component: notifications Abount notifications sent by Hackage labels May 15, 2024
@gbaz
Copy link
Contributor

gbaz commented May 15, 2024

That option should already exist? (Notification preferences are available from your user account page)

image

@andreasabel
Copy link
Member Author

andreasabel commented May 16, 2024

Ah great, I am trying the third option then!

Now that I know about it, why did my former self raise the issue, and how can we prevent such in the future?

Can the text of the notification be improved?

Currently it reads:

The dependency base-4.20.0.0 has been uploaded or revised.

You have requested to be notified when a dependency isn't accepted by any of your maintained packages.

These are your packages that require base but don't accept 4.20.0.0:

text-format-0.3.2.1
streaming-lzma-0.0.0.0
streaming-brotli-0.0.0.0
pipes-brotli-0.0.0.0
hgettext-0.1.40.1
brotli-conduit-0.0.0.0
Agda-2.6.4.3

You can adjust your notification preferences at
https://hackage.haskell.org/user/AndreasAbel/notify

It would be helpful if the list of packages could be divided into the two categories:

  1. up-to-date: They did accept the latest major version before the dependency was bumped.
  2. stale: The already did not accept the latest major version.

(In this case, only 2 packages fall into the up-to-date category and the other 5 are stale.)

The information about notification preferences could tell me that I can switch off notifications for stale or for all packages.

Can the notification settings page be improved?

Notify when a dependency is updated for any of my maintained packages:

  • Yes  
  • No
    trigger:
  • always
  • my maintained package doesn't accept the version of the newly uploaded or revised dependency
  • my maintained package doesn't accept the version of the newly uploaded or revised dependency and my package does accept the second highest version of said dependency

For one, it talks about "second highest version", so maybe it is not about major versions. But maybe I am mistaken about the major version idea, what counts is:

  • it used to accept the latest version of the dependency, but
  • it does not any more now.

I see some opportunities to reformulate the display of the options:

  1. Make a single four stage escalation list from "always" down to "never", so, integrating the "No" option as "never".
  2. Express the 3rd option in simpler terms, e.g.

    my maintained package doesn't accept the version of the newly uploaded or revised dependency but did just before the bump

The options would benefit from some help page with examples. Esp. the 3rd option is a bit unclear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: notifications Abount notifications sent by Hackage re: notifications Concerning notifications sent to Hackage users
Projects
None yet
Development

No branches or pull requests

2 participants