Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the >= 8.2 workaround once Cabal > 3.8.1.0 is released #282

Closed
Mikolaj opened this issue Aug 15, 2022 · 5 comments
Closed

Remove the >= 8.2 workaround once Cabal > 3.8.1.0 is released #282

Mikolaj opened this issue Aug 15, 2022 · 5 comments

Comments

@Mikolaj
Copy link
Member

Mikolaj commented Aug 15, 2022

The && impl(ghc >= 8.2) workaround can then be removed, because the underlying problem is fixed on master and 3.8 branch. Actually, it's also worked around as a Cabal-syntax revision on Hackage (haskell/cabal#8371), but I guess it's safer to wait for the permanent fix.

@juhp
Copy link
Contributor

juhp commented Aug 30, 2022

(Btw/tangentially cabal-install-3.6.2.0 fails to build when hackage-security pulls in Cabal-syntax-3.8)

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 30, 2022

@juhp: isn't this fixed in hackage-security 0.6.2.2?

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 30, 2022

Huh, it probably isn't --- I only fixed this for very old GHCs and for the hackage-security test suite itself. I'm afraid that's a case of haskell/cabal#8370 and it can be worked around similarly as for hackage-security test suite in #281.

That would be embarrassing. We'd need to fix old versions of cabal due to regressions in a new version.

@Mikolaj
Copy link
Member Author

Mikolaj commented Aug 30, 2022

Unless somebody has a fix for haskell/cabal#8370 and/or hackage-security.

@andreasabel
Copy link
Member

We dropped GHC 8.2, so I guess this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants