-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking for maintainers #72
Comments
@AlistairB I would like to help in maintaining it. |
@anik3t Awesome! Perhaps you could tell me a bit about your experience, timezone and anything else you think may be relevant? You are pretty much welcome to join and help regardless, but might be useful to understand what skills you have around docker and Haskell in terms of what I might need to teach you to help maintain the images. I'd also be curious to know why you are interested in helping and what kind of work in particular may be of interest. For me, I live in Melbourne, Australia UTC+10/11. I've worked in a variety of languages, but done a fair amount of Scala and I am passionate about functional programming and Haskell. I created a small github app thing in Haskell and I use these images for that, which is how I got involved as I was eager to have them updated to new GHC / Stack versions. Anyway, I think probably the best place to start would be to do the next version bump that comes along. I tried to document the full process in the readme so perhaps you could follow that and give it a go? Otherwise, there is also work to support Alpine and Windows. The alpine work is pretty much done, just waiting on GHC to have a working 9.2.X version on Alpine. Windows has a basic proof of concept working, however there is much more work around figuring out a testing (in CI primarily) strategy (in particular Stack needs additional configuration). There are also other issues that you could help with or of course I am very open to ideas to improve the images further if you have any. Anyway, that is a bit of a wall of text.. Glad you are interested in helping! |
I can help with any alpine/ubuntu based images since I use that from time to time, I've little interest in windows support right now. for example, I recnetly used |
Thanks @jappeace ! There isn't a lot of work required on the debian images, aside from providing debian bullseye support once Haskell tooling supports it. Although, any idea for improvement on the existing images is always welcome. Alpine support is more or less done, but blocked on ghci segfaulting (1, 2) for 9.2+. I don't think much is to be done other than wait on GHC developers to fix this. Although again, if you think the Alpine images can be improved that is useful. Are you interested the boring bumping of version work required in the debian images? |
yes I'll do boring version bumping, I currently don't have time to fix ghci segfaults, maybe later, sounds sorta challenging. |
oh, no you don't need to touch any of the upstream dependencies like GHC. They are aware of the issue it is up to them if they want to prioritize fixing. Debian bullseye is in a similar boat, we simply wait until cabal, stack + GHC support it officially then we can release support in docker. |
Hi, I'm interested in helping out as well. I'm maintaining the pandoc Docker images (https://github.com/pandoc/dockerfiles) and consider to restructure our build setup, which would include a switch to the official Haskell images. Helping to maintain images that we depend on would only be fair, I think. We currently support Alpine and Ubuntu, so those are the systems that I'm most interested in (and most familiar with, but not at a particularly high level of knowledge). |
How do I go about doing boring version bumps, is there some kind off notification system? |
@jappeace in terms of cabal and stack, you can watch the releases on github. For GHC I usually just know because I follow the ecosystem fairly closely. One way might be to use the RSS feed for the GHC blog. @tarleb Awesome! Sounds good thanks! I think next steps are to do one of the version bumps. Check out the github readme for the process. I guess one of you or @jappeace could do it or alternate or whatever. First in best dressed? ;) |
So stack 2.9.3 has been released. This will need to be bumped in the images. This release has a bit of an extra piece of complexity in that it is the first official stack release to support debian aarch64. Currently in the images stack is not installed on aarch64. I have updated this in #93 which uses the RC to test. This will need to be updated to the final release. I'd suggest just creating a new PR. Hopefully following the readme and looking at the images you can figure this out. The main thing to do is to update the release SHA + version. If anything is not clear from the readme let me know and I'll update it to add more info. |
Apologies, the latest wave of viruses hit pretty hard, plus trying to get pandoc 3 out the door. It seems that I won't be able to dive in before the start of next year. |
No problem at all!
…On Wed, 21 Dec 2022, 7:59 pm Albert Krewinkel, ***@***.***> wrote:
Apologies, the latest wave of viruses hit pretty hard, plus trying to get
pandoc 3 out the door. It seems that I won't be able to dive in before the
start of next year.
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADKYBPJ2X2MF2TX3OMOXVLWOLBG7ANCNFSM5UFUPXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
trying, where do you find the stack_release_key? |
A suggested update is here, if you'd enable ci I can solve issues in there as well #94 |
I added some comments to the PR @jappeace thanks. Also https://discourse.haskell.org/t/ghc-9-4-4-is-now-available/5481 is another bump that needs to happen. I'm trying to avoid doing these bumps so others can learn the ropes. I can jump in and do one if people want. |
I have gone ahead and bumped stack + GHC in #93 + docker-library/official-images#13799. I'd prefer the images to not get too far behind. I'll work on improving the docs and hopefully someone else can do the next bump. |
I have updated the readme with much more detailed instructions on doing the bumps. Please let me know if any of this is unclear or can be improved. Thanks |
https://www.haskell.org/ghc/download_ghc_9_2_6.html 9.2.6 released if anyone is interested in doing the bump? |
Hi, sorry, I don't think I can manage maintenance of this. |
No worries!
…On Sat, 11 Feb 2023, 10:01 am Jappie Klooster, ***@***.***> wrote:
Hi, sorry, I don't think I can manage maintenance of this.
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADKYBKWC6CKWTJB7OJ5F2DWW3CEJANCNFSM5UFUPXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@tarleb how about you? |
👍 I'll give it a try later today. |
@tarleb are you interested / have time to do 9.2.7 too? |
Yes to both. I might not get to it today, but tomorrow should work. |
Thanks again! If you still keen I'm happy to add you as an official maintainer? I'll probably hang around for a few months yet chipping in. After that you can still ping me if you want another opinion. (It would be nice to get more maintainers of course too..) |
Slightly scared, but sounds good. Having more maintainers would be great of course; it's sometimes hard to do updates in a timely manner if too many other things came up at the same time. |
Awesome! Yeah, there is no pressure to do things in a timely manner. Any help doing updates is helping out the Haskell ecosystem. If people who use the images really want an update they can get involved / submit a PR if they need (which is how I got involved). Even if you decide to step away, ultimately the Haskell Foundation or someone will step up to maintain them. So I'd suggest giving only what time you can comfortably do. I've added you as an admin to this repo. The other thing is to add you as a maintainer here. I can do it if you give me what email you want to use, or you can submit a PR and I can approve. |
Do you still need help maintaining the docker images? |
@rickprice yup definitely. If you want to get involved you could give the GHC 9.2.8 bump a go? |
Okay, I will try to do something in the next day or so. |
Great. Hopefully the readme is self-explanatory. |
Ok, now seems like a reasonable time to step away @tarleb @develop7 . I've cleaned up a few last PRs / issues and removed my access. I'm going to unfollow the repo, but feel free to ping me if you have any questions. I guess I'll close this particular issue. Of course you may want to open another similar one depending on how you are going. Best of luck! |
@AlistairB Thank you for your commitment over the last 3.5 years. |
I am currently the only maintainer.. 😅
Useful skills
Roughly in order of usefulness.
However, none of these are a hard requirement. The bumping of versions is a pretty simple process. Happy to pass on my knowledge if someone is interested but hasn't done much docker or whatever.
To make it clear, there is a very low level of knowledge required to get involved.
What do maintainers do?
Primarily, bump versions of GHC, cabal + stack when they are released. These are bumped first in this repo, then in the official images repo.
Otherwise, look for ways to improve the images, or add more OS support.
I am looking to step down
Update: I am looking to step down end of Jan 2023 (happy to stick around longer to advise if needed). I'll post this around and hopefully people are interested.
Update 2: I am around and will approve and merge PRs, but will not make any more commits in the hope that others will step up. At the latest I will leave the project end of 2023.
Next steps
If you are interested, let me know a bit about yourself and why you are interested. Then I think you can do the next version bumps that come along, or dive into other more thorny work if you want.
The text was updated successfully, but these errors were encountered: