-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling Darwin jobs on GitLab CI #9864
Comments
Not really a "user question" hehe |
@chreekat uhm, looking at #9827 (comment) you better make sure that Homebrew switches to ghcup's bindists before disabling the runner. |
@Kleidukos thanks for bringing that to my attention! |
@chreekat: thank you for the heads-up.
But they are building from source, right? I agree, for their sake, the Darwin-building of the source should be tested, but it's already tested on github (though the extra test on gitlab is valuable, in general, especially that it's release-focused). |
Oh, I see, they build from source, but bootstrap with bindist! So you are right, this is a blocker. But otherwise, I think #9827 indicates our release CI is now going to be focused on testing the next release artifact-generation step continuously and in advance of the release (moreover, in a different environment that the PR CI). Opportunistically, we can just as well publish the generated artifacts at release time. Both use cases should be fine with (temporarily) reduced set of architectures. Generally, piggy-backing on GHC CI, which is relatively low-cost, seems like a great fit. That means, GHC CI takes precedence and only minimal extra cabal-specific tweaks sound cost-effective. |
BTW, i guess they could just as well bootstrap with their own Homebrew last-cabal-version binaries? |
We can probably ask @fishtreesugar on their opinion? |
I decided to look into it, because if we know somebody is using the bindists, I'd like to keep making them available. It didn't take long for me to find https://discourse.haskell.org/t/solved-trouble-building-unix-package-on-macos-ld-unknown-option-no-fixup-chains/7772/15 . I'll just try using a different version of GHC. |
Closing since I won't disable them. |
Still, @fishtreesugar, do you think it could be relatively easy to insulate Homebrew from our provisional distribution channel by, e.g., using for bootstrapping the previous Homebrew binaries or a specialized distribution service, meaning, ghcup? |
I believe it should be acceptable, though I am only an occasional contributor and am not certain of the official stance. |
OK, thank you, good to know. |
Hi folks,
I am likely going to disable Darwin jobs in GitLab's CI for the following reasons.
Any strong reasons I should not do so?
The text was updated successfully, but these errors were encountered: