Swagger instances for UVerb #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatting
commented
Nov 5, 2020
|
I think this now ready for review |
fisx
requested changes
Nov 13, 2020
Comment on lines
24
to
25
| -- @since <TODO> | ||
| #if __GLASGOW_HASKELL__ >= 881 |
There was a problem hiding this comment.
Suggested change
| -- @since <TODO> | |
| #if __GLASGOW_HASKELL__ >= 881 | |
| #if __GLASGOW_HASKELL__ >= 881 | |
| -- @since <TODO> |
Not sure if this breaks anything, but it seems more honest to me. (Please ignore if you're no more confident than me.)
There was a problem hiding this comment.
Hh, yes, missed that. Done
fisx
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Union Verbs, which were introduced recently to servant: haskell-servant/servant#1314