Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use monotonic clock instead of system clock #13

Open
bergey opened this issue Dec 12, 2019 · 1 comment · May be fixed by #25
Open

use monotonic clock instead of system clock #13

bergey opened this issue Dec 12, 2019 · 1 comment · May be fixed by #25

Comments

@bergey
Copy link

bergey commented Dec 12, 2019

What do you think about using a monotonic clock like the one in System.Clock instead of getCurrentTime? System clocks occasionally move backwards in order to correct clock skew, which makes a mess of latency statistics.

(To be clear, I haven't yet seen this issue with this particular library, but it's a known challenge.)

Happy to follow up with a PR if you like the idea.

@alpmestan
Copy link

alpmestan commented Dec 19, 2019

Sounds like a good idea, I don't see a good reason not to switch - e.g clock depends just on base and ghc-prim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants