Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withMappedBuffer - Restore buffer object before unbinding #48

Open
blitzcode opened this issue Dec 26, 2013 · 0 comments
Open

withMappedBuffer - Restore buffer object before unbinding #48

blitzcode opened this issue Dec 26, 2013 · 0 comments

Comments

@blitzcode
Copy link

The withMappedBuffer helper function can be unsafe if the inner changes the VAO/VBO bindings and either forgets to change it back or gets interrupted by an exception.

withMappedBuffer could query the current buffer object at the beginning and restore it inside its finally block before calling unmapBuffer.

I'm not sure if there is a good reason for not doing this, but I thought I at least suggest this change here.

blitzcode added a commit to blitzcode/jacky that referenced this issue May 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant