Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide motivation and clarity on Ubuntu version selection #741

Open
ysangkok opened this issue Jul 11, 2024 · 3 comments
Open

Provide motivation and clarity on Ubuntu version selection #741

ysangkok opened this issue Jul 11, 2024 · 3 comments

Comments

@ysangkok
Copy link

ysangkok commented Jul 11, 2024

As @liskin notes, the source still specifies bionic as the default, but it doesn't seem to be true.

In the source it seems that Xenial and Bionic are valid options: https://github.com/haskell-CI/haskell-ci/blob/5e5b27d74f90e73905c4f56f4aefe521f97879f0/src/HaskellCI/Config/Ubuntu.hs

Ok, bionic might not be the default, but it is still supported, right? I run

# oldproj is 'tested-with: GHC ==8.0.2'
$ haskell-ci-0.19.20240702 github oldproj.cabal --distribution bionic
*ERROR* bionicdistribution is not supported

This error message is different from if I specify some garbage string. So bionic is recognized but not supported? But not usable? If the point of recognizing it is to provide a better error message, it might make sense to make Haskell-CI link to @hasufell's comment on the github thread so that the user understands why Haskell-CI refuses to use Bionic and Xenial.

I saw this comment saying that the runsOn version isn't that important. But now that GitHub broke Haskell-CI with people using Ubuntu Bionic, it does seem kinda important. I don't understand the value in setting the default to 20.04 (Focal) now. Because if Haskell-CI now sets the Ubuntu to version Focal, I get the impression from the breakage of Bionic that those CI plans with Focal will get invalid earlier than if Haskell-CI used Ubuntu 24.04 (Noble). If Haskell-CI generated CI plans with Noble, those plans would stay valid for longer. That would provide a better user experience since people wouldn't need to upgrade Haskell-CI as soon as they otherwise would.

@phadej
Copy link
Collaborator

phadej commented Jul 11, 2024

This issue makes me reconsider whether to publish haskell-ci on Hackage at all.

Many people use the master version, and I suggest you should too if you run into some problems with the version you have.

@endgame
Copy link

endgame commented Jul 19, 2024

See also #739

Having it on Hackage makes it readily available in nixpkgs, which I find quite useful. How often does it change and need a new release?

@phadej
Copy link
Collaborator

phadej commented Jul 19, 2024

How often does it change and need a new release?

https://github.com/haskell-CI/haskell-ci/commits/master/ looks like every other week at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants