Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor protobuf usage throughout #74

Open
randypitcherii opened this issue Apr 12, 2018 · 0 comments
Open

refactor protobuf usage throughout #74

randypitcherii opened this issue Apr 12, 2018 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers in progress

Comments

@randypitcherii
Copy link
Contributor

Proto objects in scala may currently use a fragile instantiation. make sure each protobuf useage in the scala applications declare an empty proto object and only uses the getters and setters to fill the proto object.

This will avoid hard to debug errors if proto definitions change over time. A change that would result in a bad proto will be more likely to fail at compile time if we use the getters / setters.

@randypitcherii randypitcherii self-assigned this Apr 12, 2018
@randypitcherii randypitcherii added bug Something isn't working enhancement New feature or request good first issue Good for newcomers in progress labels Apr 12, 2018
@randypitcherii randypitcherii changed the title refactor protobuf useage throughout refactor protobuf usage throughout May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers in progress
Projects
None yet
Development

No branches or pull requests

1 participant