Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add a GHA that fails on PRs that contain a :SKIP test #2667

Open
BBBmau opened this issue Jan 14, 2025 · 1 comment
Open

CI: add a GHA that fails on PRs that contain a :SKIP test #2667

BBBmau opened this issue Jan 14, 2025 · 1 comment
Assignees

Comments

@BBBmau
Copy link
Contributor

BBBmau commented Jan 14, 2025

Description

We sometimes run into PRs introducing tests that must be skipped due to k8s environment mismatch. This leads to CI returning all passing with the test never actually being tested. This can be misleading to reviewers on first glance when looking at a 100% passing PR.

A solution would be to include a GHA that checks the PR for new tests being added and to check whether or not it's being skipped. GHA would then fail providing that the following tests in the PR are skipped. The only way to bypass this would be to include a label (ideally the label would be added after the reviewer does their manual test of the PR). Label could be named manually-tested.

Here's an example of some confusion as to why CI was passing before realizing that it's being skipped.

#2557 (comment)

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@JaylonmcShan03
Copy link
Contributor

Thanks for tracking this! I can put this on my backlog for Q1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants