Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swingset fails to load components on Windows #54

Open
jmfury opened this issue Feb 12, 2023 · 1 comment
Open

Swingset fails to load components on Windows #54

jmfury opened this issue Feb 12, 2023 · 1 comment

Comments

@jmfury
Copy link
Contributor

jmfury commented Feb 12, 2023

👋 It looks like since globby doesn't support Windows paths (sindresorhus/globby#130 & sindresorhus/globby#127), the globbing and path operations across swingset silently fail on Windows machines.

To be clear, the package still compiles and no errors are thrown, yet when running on Windows, components-loader.js won't find any components to build into Next.js pages.

I've got a branch working that addresses these issues, but it's tricky since globby, path, and webpack need a variety of path styles. I have successfully run the peerComponents example with [some ugly] changes made locally 🎉

I'll have a PR up for this once I do a bit of clean up on my fork 😄

cc: @BRKalow

@jmfury
Copy link
Contributor Author

jmfury commented Feb 13, 2023

Did not see #37 prior to posting this issue 😅

#55 is up now, up to date w/ main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant