Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track LogNoop commit index #622

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions raft.go
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,12 @@
break
}

// Update the Noop commit index so clients know the index
// at which leadership was conclusively established.
if commitLog.log.Type == LogNoop {
r.setNoopCommitindex(commitLog.log.Index)

Check failure on line 819 in raft.go

View workflow job for this annotation

GitHub Actions / go-fmt-and-vet

r.setNoopCommitindex undefined (type *Raft has no field or method setNoopCommitindex)
}

// Measure the commit time
metrics.MeasureSince([]string{"raft", "commitTime"}, commitLog.dispatch)
groupReady = append(groupReady, e)
Expand Down
Loading