dynamic host volumes: Enterprise stubs and refactor API #24545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most Nomad upsert RPCs accept a single object with the notable exception of CSI. But in CSI we don't actually expose this to users except through the Go API. It deeply complicates how we present errors to users, especially once Sentinel policy enforcement enters the mix. Refactor the `HostVolume.Create` and `HostVolume.Register` RPCs to take a single volume instead of a slice of volumes. Add a stub function for Enterprise policy enforcement. This requires splitting out placement from the `createVolume` function so that we can ensure we've completed placement before trying to enforce policy. Ref: #24479
tgross
commented
Nov 22, 2024
Comment on lines
+4
to
+5
| //go:build !ent | ||
| // +build !ent |
There was a problem hiding this comment.
Note for reviewers: https://github.com/hashicorp/nomad-enterprise/commit/5890c50480738bfecb7eca9560218dacea82d690 has my rough prototype for what this will look like in Nomad Enterprise, so the signature here should be what we want.
pkazmierczak
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Code LGTM, but if we now start returning objects instead of arrays on create and register API calls, shouldn't this be considered a breaking change somehow? People will still be able to make the same requests, but whatever consumes their responses will break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Nomad upsert RPCs accept a single object with the notable exception of CSI. But in CSI we don't actually expose this to users except through the Go API. It deeply complicates how we present errors to users, especially once Sentinel policy enforcement enters the mix.
Refactor the
HostVolume.CreateandHostVolume.RegisterRPCs to take a single volume instead of a slice of volumes.Add a stub function for Enterprise policy enforcement. This requires splitting out placement from the
createVolumefunction so that we can ensure we've completed placement before trying to enforce policy.Ref: #24479