-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marshal #34
Comments
I tried to gob and got |
@backspace +1 |
Would be very nice to have this. |
My slight hesitation is that gob is not the format most projects would need if they wanted to encode to disk or network since it's not cross-platform. Encoding to GOB then decoding to something else and re-encoding to JSON or protobuf seems painful. An alternative would be to add a But in reality that method would just be a simple iteration over the tree and assignment into a map - something the caller could do with a few lines of code anyway and probably more efficiently as they might not need interim map copy. So I'd be inclined to follow the Go convention of not including code that is trivial to write in low-level libs. What do you all think? Would having an example in the README of how to encode to Gob be a reasonable alternative? |
I think that'd be great! |
Would it be possible to add Marshal/Unmarshal functions? I'm creating very large tries and it burns my lap to generate them 🔥 I'd like to save them to disk so I don't have to regen again.
Would that be possible?
The text was updated successfully, but these errors were encountered: