Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceEndpoint port gets overwritten #2098

Open
jbair06 opened this issue Nov 23, 2024 · 1 comment
Open

ServiceEndpoint port gets overwritten #2098

jbair06 opened this issue Nov 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jbair06
Copy link
Member

jbair06 commented Nov 23, 2024

Description

When I create a NodeUpdate or NodeCreate transaction and set the proper endpoints with the proper ports, then serialize and deserialize the transaction, the endpoint ports are now different. ServiceEndpoint.fromProtobuf checks for the port to be 0 or 50111, then sets it to 50211 if so.

Steps to reproduce

Remove the check and overwriting of the port when deserializing the endpoints. 50111 is a valid port for gossip Endpoints.

Additional context

No response

Hedera network

No response

Version

2.44.0

Operating system

None

@jbair06 jbair06 added the bug Something isn't working label Nov 23, 2024
@ElijahLynn
Copy link

if (port == 0 || port == 50111) {
port = 50211;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants