You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The two classes (identical in JS and other SDKs) look strange. The classes are wrappers around protobuf classes that created by hand but do not provide any additional information. Can we please check if the classes are really needed? I assume the classes (enums) created by protobuf are already good enough and we do not need the additonal handmade classes.
The text was updated successfully, but these errors were encountered:
Hi @hendrikebbers . It seems like Status could be removed, but I am not sure if there are not any users that are using the Status struct specifically for comparison. RequestType would not be directly used, I think.
We could use the protobuf classes directly, but I cannot guarantee that someone is not using our own implementation, since they are public classes.
We could @Deprecate them and use the protobufs. After some time we could remove the 2 deprecated classes.
The two classes (identical in JS and other SDKs) look strange. The classes are wrappers around protobuf classes that created by hand but do not provide any additional information. Can we please check if the classes are really needed? I assume the classes (enums) created by protobuf are already good enough and we do not need the additonal handmade classes.
The text was updated successfully, but these errors were encountered: