Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HBAR Rate Limit Redesign] Add OPERATOR tier #3099

Closed
victor-yanev opened this issue Oct 15, 2024 · 0 comments · Fixed by #3316 or #3338 · May be fixed by #3331
Closed

[HBAR Rate Limit Redesign] Add OPERATOR tier #3099

victor-yanev opened this issue Oct 15, 2024 · 0 comments · Fixed by #3316 or #3338 · May be fixed by #3331
Assignees
Labels
enhancement New feature or request Technical Debt Issue which resolves technical debt
Milestone

Comments

@victor-yanev
Copy link
Contributor

victor-yanev commented Oct 15, 2024

Instead of tracking the remaining total budget in-memory inside HbarLimitService (we would have to divide it by the number of Kubernetes instances, etc - it is creating unnecessary complexity in the configurations), we could create a new subscription tier (SubscriptionTier.OPERATOR) and add a pre-configured spending plan in the JSON configuration file which links the ETH address(es) of the relay operator account(s) to it.

In this way we can only set the total limit for the OPERATOR tier to HBAR_RATE_LIMIT_TINYBAR and it will be shared by all instances of the relay.

@victor-yanev victor-yanev added enhancement New feature or request Technical Debt Issue which resolves technical debt labels Oct 15, 2024
@victor-yanev victor-yanev changed the title Add OPERATOR tier [HBAR Rate Limit Redesign] Add OPERATOR tier (post-release) Oct 15, 2024
@quiet-node quiet-node self-assigned this Nov 4, 2024
@quiet-node quiet-node moved this from Backlog to Tasks In Progress in Smart Contract Sprint Board Nov 4, 2024
@quiet-node quiet-node changed the title [HBAR Rate Limit Redesign] Add OPERATOR tier (post-release) [HBAR Rate Limit Redesign] Add OPERATOR tier Nov 4, 2024
@quiet-node quiet-node moved this from Tasks In Progress to Sprint Backlog in Smart Contract Sprint Board Nov 11, 2024
@quiet-node quiet-node removed their assignment Nov 13, 2024
@quiet-node quiet-node self-assigned this Nov 22, 2024
@quiet-node quiet-node added this to the 0.62.0 milestone Nov 22, 2024
@quiet-node quiet-node moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Nov 22, 2024
@quiet-node quiet-node removed their assignment Dec 5, 2024
@quiet-node quiet-node moved this from Tasks In Progress to Sprint Backlog in Smart Contract Sprint Board Dec 5, 2024
@victor-yanev victor-yanev moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Dec 9, 2024
@victor-yanev victor-yanev modified the milestones: 0.62.0, 0.63.0 Dec 9, 2024
@victor-yanev victor-yanev moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Dec 17, 2024
@victor-yanev victor-yanev moved this from Done to In Review in Smart Contract Sprint Board Dec 17, 2024
@victor-yanev victor-yanev moved this from In Review to Done in Smart Contract Sprint Board Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment