-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Infro PR Checks? #259
Comments
@colethienes interesting. I wanted to give it a try but I don't agree to the permissions "Act on your behalf" is too broad and I wouldn't ever agree to that. |
Got it. If you don't want to give a third party permissions, I think I will most likely open source. If I do, would it be most useful to you to open source a Github action or Github app? |
I open sourced a version as a GitHub action here! https://github.com/infro-io/infro-core?tab=readme-ov-file#as-a-github-action |
I had a quick look and saw infro-io/comment-diffs-action#1 as a problem |
@colethienes added. In #251 (comment) I can see it shows diffs from live cluster to repo. The live cluster might not currently be at the previous HEAD. This can make the PR comment pretty misleading |
I noticed that this repo uses Argo CD, and I thought I’d let you know that I recently released a Github app called Infro that several companies use internally that allows Argo CD users to preview Kubernetes changes in Github pull requests before they merge. I’m providing it for free to open source projects (here’s an example in the wild). Here’s a setup guide with links to documentation. It’s in early stages, so I’m sure there will be warts. All feedback is welcome!
The text was updated successfully, but these errors were encountered: