Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Infro PR Checks? #259

Closed
colethienes opened this issue Feb 27, 2024 · 5 comments
Closed

Add Infro PR Checks? #259

colethienes opened this issue Feb 27, 2024 · 5 comments

Comments

@colethienes
Copy link

colethienes commented Feb 27, 2024

I noticed that this repo uses Argo CD, and I thought I’d let you know that I recently released a Github app called Infro that several companies use internally that allows Argo CD users to preview Kubernetes changes in Github pull requests before they merge. I’m providing it for free to open source projects (here’s an example in the wild). Here’s a setup guide with links to documentation. It’s in early stages, so I’m sure there will be warts. All feedback is welcome!

@daurnimator
Copy link
Member

@colethienes interesting. I wanted to give it a try but I don't agree to the permissions

image

"Act on your behalf" is too broad and I wouldn't ever agree to that.

@colethienes
Copy link
Author

Got it. If you don't want to give a third party permissions, I think I will most likely open source. If I do, would it be most useful to you to open source a Github action or Github app?

@colethienes
Copy link
Author

I open sourced a version as a GitHub action here! https://github.com/infro-io/infro-core?tab=readme-ov-file#as-a-github-action

@daurnimator
Copy link
Member

I open sourced a version as a GitHub action here! https://github.com/infro-io/infro-core?tab=readme-ov-file#as-a-github-action

I had a quick look and saw infro-io/comment-diffs-action#1 as a problem

daurnimator added a commit that referenced this issue Sep 23, 2024
@daurnimator
Copy link
Member

@colethienes added.

In #251 (comment) I can see it shows diffs from live cluster to repo. The live cluster might not currently be at the previous HEAD. This can make the PR comment pretty misleading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants