Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap requestargs and requestquery #230

Open
jace opened this issue Jun 14, 2019 · 0 comments
Open

Swap requestargs and requestquery #230

jace opened this issue Jun 14, 2019 · 0 comments
Assignees

Comments

@jace
Copy link
Member

jace commented Jun 14, 2019

Ticket #132 was closed prematurely citing existing use. requestargs continues to cause confusion as it suggests that request.args will be consulted, while actually consulting request.values. To fix:

  1. Rename requestargs to requestvalues
  2. Temporarily alias it back to requestargs
  3. Audit all code that is using requestargs for POST requests and switch to requestvalues or requestform as appropriate
  4. Drop the alias and rename requestquery to requestargs (retaining an alias)
@jace jace self-assigned this Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant