You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I updated winit to 1.29.2, and, because there doesn't seem to be support for it already, decided to quickly update the platform code.
Fortunately, it's all pretty smooth! Although there are a bunch of breaking changes, everything seems to work just fine except one thing: winit::event::WindowEvent::ScaleFactorChanged
The current implementation uses new_inner_size, but this field has been replaced by inner_size_writer in the new version of winit. The new inner_size_writer doesn't allow you to get the suggested inner_size (i.e. new_inner_size) for some reason... So we have to have access to the Window (for Window::inner_size()) Maybe I haven't looked hard enough, but I don't see any way to access the window from anywhere inside Platform (the optional argument in end_frame doesn't work)
My question is: is passing a window reference to handle_event the only way to do this for now?
Note: I will make a pull request when this gets resolved (or should I do it now?)
The text was updated successfully, but these errors were encountered:
I updated winit to 1.29.2, and, because there doesn't seem to be support for it already, decided to quickly update the platform code.
Fortunately, it's all pretty smooth! Although there are a bunch of breaking changes, everything seems to work just fine except one thing:
winit::event::WindowEvent::ScaleFactorChanged
The current implementation uses
new_inner_size
, but this field has been replaced byinner_size_writer
in the new version of winit. The newinner_size_writer
doesn't allow you to get the suggested inner_size (i.e.new_inner_size
) for some reason... So we have to have access to theWindow
(forWindow::inner_size()
) Maybe I haven't looked hard enough, but I don't see any way to access the window from anywhere insidePlatform
(the optional argument inend_frame
doesn't work)My question is: is passing a window reference to
handle_event
the only way to do this for now?Note: I will make a pull request when this gets resolved (or should I do it now?)
The text was updated successfully, but these errors were encountered: