From 4fee40d847199495f19bf1209b12f67c11e84f54 Mon Sep 17 00:00:00 2001 From: Vikas Bansal <43470111+vikasvb90@users.noreply.github.com> Date: Fri, 6 Oct 2023 12:14:05 +0000 Subject: [PATCH] Fix to include static settings in addition to dynamic repo metadata settings during s3 plugin reload (#10452) Signed-off-by: vikasvb90 --- .../java/org/opensearch/repositories/s3/S3Repository.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java b/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java index a69309d9e7a6f..bbc3451be1535 100644 --- a/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java +++ b/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java @@ -374,9 +374,8 @@ public void reload(RepositoryMetadata newRepositoryMetadata) { readRepositoryMetadata(); // Reload configs for S3RepositoryPlugin - final Map clientsSettings = S3ClientSettings.load(metadata.settings(), pluginConfigPath); - service.refreshAndClearCache(clientsSettings); - s3AsyncService.refreshAndClearCache(clientsSettings); + service.settings(metadata); + s3AsyncService.settings(metadata); // Reload configs for S3BlobStore BlobStore blobStore = getBlobStore();