Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-resolvable notes are not shown in winbar #411

Closed
3 tasks done
jakubbortlik opened this issue Oct 31, 2024 · 3 comments
Closed
3 tasks done

Non-resolvable notes are not shown in winbar #411

jakubbortlik opened this issue Oct 31, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@jakubbortlik
Copy link
Collaborator

Prerequsities

  • I'm on the latest version of the plugin
  • I've installed the required dependencies
  • I've run :h gitlab.nvim.troubleshooting and followed the steps there

Bug Description

The winbar of the discussion tree is useful in showing the number of threads that need to be addressed. Currently, however, it doesn't show the number of non-resolvable notes (i.e., notes that are not a thread with the "Resolve" button). This makes it possible to miss such a note completely in gitlab.nvim

Reproduction Steps

  1. In Gitlab online create a "Comment" (not a Thread!), see screenshot below
  2. Check out the feature branch
  3. Open Neovim
  4. If there are no other notes in the MR and the discussion tree is showing Inline comments, the winbar doesn't give you any hint that there are any Notes at all.

Suggested fix

Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of resolvable/resolved to resolved/resolvable, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this: Notes (2 comments; 1/5 threads; 2 drafts).

Screenshots

image

@jakubbortlik jakubbortlik added the bug Something isn't working label Oct 31, 2024
@harrisoncramer
Copy link
Owner

Hey, thank you for filing this issue Jakub.

"Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of resolvable/resolved to resolved/resolvable, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this: Notes (2 comments; 1/5 threads; 2 drafts)."

This sounds good to me ☝️ are you willing to submit a pull request for this?

@jakubbortlik
Copy link
Collaborator Author

Hi, Harrison, sure, I will submit a PR. First I'll finish some work in order to close #385 and then I'll fix the winbar in this issue.

@harrisoncramer
Copy link
Owner

Addressed by #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants