You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've run :h gitlab.nvim.troubleshooting and followed the steps there
Bug Description
The winbar of the discussion tree is useful in showing the number of threads that need to be addressed. Currently, however, it doesn't show the number of non-resolvable notes (i.e., notes that are not a thread with the "Resolve" button). This makes it possible to miss such a note completely in gitlab.nvim
Reproduction Steps
In Gitlab online create a "Comment" (not a Thread!), see screenshot below
Check out the feature branch
Open Neovim
If there are no other notes in the MR and the discussion tree is showing Inline comments, the winbar doesn't give you any hint that there are any Notes at all.
Suggested fix
Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of resolvable/resolved to resolved/resolvable, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this: Notes (2 comments; 1/5 threads; 2 drafts).
Screenshots
The text was updated successfully, but these errors were encountered:
"Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of resolvable/resolved to resolved/resolvable, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this: Notes (2 comments; 1/5 threads; 2 drafts)."
This sounds good to me ☝️ are you willing to submit a pull request for this?
Prerequsities
:h gitlab.nvim.troubleshooting
and followed the steps thereBug Description
The winbar of the discussion tree is useful in showing the number of threads that need to be addressed. Currently, however, it doesn't show the number of non-resolvable notes (i.e., notes that are not a thread with the "Resolve" button). This makes it possible to miss such a note completely in
gitlab.nvim
Reproduction Steps
Suggested fix
Add count of non-resolvable notes to the winbar, possibly also replace "resolved" with "threads" and swap the order of
resolvable/resolved
toresolved/resolvable
, as it corresponds better to the way of saying "1 out of 5 are resolved". The final winbar text could look like this:Notes (2 comments; 1/5 threads; 2 drafts)
.Screenshots
The text was updated successfully, but these errors were encountered: