Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case issue with deposit proofs calculation #150

Open
mkalinin opened this issue Jun 21, 2019 · 0 comments
Open

Edge case issue with deposit proofs calculation #150

mkalinin opened this issue Jun 21, 2019 · 0 comments
Labels
bug Something isn't working deposit contract Deposit contract integration

Comments

@mkalinin
Copy link
Contributor

Bug

When deposits in a tree segment exceeds block capacity, DepositContract.peekDeposits returns incorrect deposit proofs as it treats deposit count as tree size.

https://github.com/harmony-dev/beacon-chain-java/blob/develop/pow/core/src/main/java/org/ethereum/beacon/pow/AbstractDepositContract.java#L198-L211
@mkalinin mkalinin added bug Something isn't working deposit contract Deposit contract integration labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working deposit contract Deposit contract integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkalinin