Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound rate limits #6

Open
acharkizakaria opened this issue Aug 1, 2017 · 4 comments
Open

Outbound rate limits #6

acharkizakaria opened this issue Aug 1, 2017 · 4 comments

Comments

@acharkizakaria
Copy link

Hi guys, I'm having a problem during the implementation of outbound rate limits, it seems to work just for the first time for the outbound part.

Example :

If I'm using the following Config in limit.ini :

[outbound]
enabled=true
domain=1
delay=10

Then queuing 5 mails.

Expected :
Deliver 1 mail every 10 seconds.

Current behaviour :
Deliver the first mail then delayed the rest '4' mails for 10 seconds (as expected), but after the first 10 seconds the 'send_mail' hook will be called and delayed the '4' mails another time and keep delay the delivery every 10 seconds... without delivering.

NOTE : I think that happen because of the TOTAL that will be incremented every time so the count variable will be always greater than limit and will reach the delivered condition just the first time :

if (count <= limit) return next();

Thanks in advance.

@msimerson
Copy link
Member

Note: see also haraka/Haraka#2006

@MatthieuHPP
Copy link

Hello,
I would like to implement this plugin and the outbound rate limit in particular. Has this bug been fixed ?
Many thanks
Matthieu

@acharkizakaria
Copy link
Author

acharkizakaria commented Oct 3, 2017 via email

@msimerson
Copy link
Member

This might be related to #56 which I just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants