Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absence of generic class MDM_TXX and ORU_RXX #102

Open
Bhavishya-jasuja opened this issue Sep 26, 2023 · 2 comments
Open

Absence of generic class MDM_TXX and ORU_RXX #102

Bhavishya-jasuja opened this issue Sep 26, 2023 · 2 comments

Comments

@Bhavishya-jasuja
Copy link

As I observe, we have ADT_XXX for all our ADT events. However, we don't seem to have a similar prefix for our MDM and ORU events. Is there any specific reason for this inconsistency? To ensure clarity and maintainability in our codebase, I feel that we should have MDM_TXX as well as ORU_RXX in the library so that code implementation can be used in more dynamic scenarios. Let's discuss whether there's a valid reason for not having a prefix for MDM and ORU events or if it's an oversight that needs to be addressed.

If no one has contributed to this issue yet, I'd like to express my interest in contributing to it. I believe resolving this inconsistency can improve the overall organization of our codebase and make it easier for developers to work with our event system. Please let me know how I can get started with this contribution, including any guidelines or specific steps to follow.

@milkshakeuk
Copy link

Are you referring to this by any chance?

https://hapifhir.github.io/hapi-hl7v2/hapi-faq.html#missing_messages

@jamesagnew
Copy link
Contributor

We have never created any generic structures for other message types because nobody has ever needed any. If you wanted to try and modify the generator to also generate other types, we'd certainly be willing to look at the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants