Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof fusermount{3, 4, 5,...} call #422

Closed
probonopd opened this issue Apr 30, 2022 · 1 comment
Closed

Future-proof fusermount{3, 4, 5,...} call #422

probonopd opened this issue Apr 30, 2022 · 1 comment

Comments

@probonopd
Copy link

probonopd commented Apr 30, 2022

Current behavior:

  • Check for fusermount3,
  • Fall back to fusermount

Suggested behavior:

  • Check for fusermountN with N= any integer and use the highest one
  • fall back to fusermount

Advantage:
Exisitng binaries will continue to work once there will be fusermount4 instead of fusermount3.

go-fuse/fuse/mount_linux.go

Lines 225 to 232 in 934a183

// fusermountBinary returns the path to the `fusermount3` binary, or, if not
// found, the `fusermount` binary.
func fusermountBinary() (string, error) {
if path, err := lookPathFallback("fusermount3", "/bin"); err == nil {
return path, nil
}
return lookPathFallback("fusermount", "/bin")
}

References:

@hanwen
Copy link
Owner

hanwen commented Apr 8, 2023

If fusermount4 introduces a new calling convention (typically, this is what you introduce a new version number for!), then this would fail in mysterious ways, so I think this is best left alone.

@hanwen hanwen closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants