Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify hlarp as a requirement #9

Open
tavinathanson opened this issue May 24, 2017 · 6 comments
Open

Specify hlarp as a requirement #9

tavinathanson opened this issue May 24, 2017 · 6 comments

Comments

@tavinathanson
Copy link
Member

No description provided.

@armish
Copy link
Member

armish commented May 24, 2017

@rleonid: can you remind me what was the issue with the biokepi's hlarp again? Should we just run within the pipeline instead of dealing with these external uses?

@tavinathanson
Copy link
Member Author

@armish since Discohorts supports any pipeline, I don't think we can rely on the pipeline running hlarp. I haven't had issues running it locally; I'm curious what the issues are that you're referring to?

@rleonid
Copy link
Member

rleonid commented May 25, 2017

This one ?

@armish
Copy link
Member

armish commented May 26, 2017

@rleonid: oh - I remember that hack! But does the version in the biokepi any different than the one that is currently on the dev channel and installed via opam?

@tavinathanson: was just thinking that it might be much more convenient to just append |> Bfx.hlarp ... to the pipeline scripts instead of pulling hlarp into the discohorts, but never mind my suggestion if it is not that big of hassle at this point ;)

@tavinathanson
Copy link
Member Author

@armish good point. I could go either way since discohorts is such a collection of hacks right now. Also open to both options working simultaneously.

@rleonid
Copy link
Member

rleonid commented May 26, 2017

@armish If we

  1. set extract_alleles to false in the scripts and
  2. update the biokepi_tracker branch then we can use the master branch. I'd be happy to do the later, but I'm not certain of what else might break. @ihodes Do you have any idea's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants