Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Open Saved Data #105

Closed
NikolayMurha opened this issue Oct 23, 2024 · 2 comments
Closed

Feature request - Open Saved Data #105

NikolayMurha opened this issue Oct 23, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@NikolayMurha
Copy link

Greetings

Thanks for the helful and usable Serial Monitor!
It helps me a lot to shoot and watch logs in real time and save them to a file.
But it would be very useful to load the already saved data from the file for viewing.
I can make several files at work, and often need to view it again or compare them, and the function to upload it again is missing.

I realize this goes against the app's name a bit, but it would be a very useful feature!

Thank you!

@hacknus hacknus added the enhancement New feature or request label Oct 23, 2024
@hacknus
Copy link
Owner

hacknus commented Oct 23, 2024

Thanks for the input!

Yes, that would be a nice feature. Should probably go into the main thread:

fn main_thread(
    sync_tx: Sender<bool>,
    data_lock: Arc<RwLock<DataContainer>>,
    print_lock: Arc<RwLock<Vec<Print>>>,
    raw_data_rx: Receiver<Packet>,
    save_rx: Receiver<FileOptions>,
    clear_rx: Receiver<bool>,
) {
    // receive from raw_data_rx...
    // ...
    // if file is loaded, send file content, else send raw content
    // if let Ok(mut write_guard) = data_lock.write() {
    //    *write_guard = data.clone();
    // }
}

@hacknus hacknus added the help wanted Extra attention is needed label Oct 23, 2024
@hacknus
Copy link
Owner

hacknus commented Dec 22, 2024

implemented in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants