ChemEnvSiteFingerprint.from_preset() removal of not-implemented CEs #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #945.
LocalGeometryFinder
)ChemEnvSiteFingerprint
for Ni3Al for a site with CN=12 that would have failed due to non-implemented S:12 CEChemEnvSiteFingerprint.from_preset()
are implemented geometries in theLocalGeometryFinder
. This should ensure that future changes in the presetce_types
or in pymatgen (although probably no "deactivation" of existing CEs) will be detected by the failing test, if problematic.Tagging @ml-evs for review (thank you!)
Tagging @davidwaroquiers in case you have something to add on issue #945 or this PR (e.g., is the
deactivate
attribute of CEs in ChemEnv going to be changed in future pymatgen versions?).