-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JavaScript so that Events page sources meeting data from vrms_data.json #6023
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hi @njackman-2344. I'm possibly going to increase the scope of this issue. I am leaving a note for the dev lead here and you will see the discussion Hi @hackforla/website-merge I realized we are having the events page refactored in this issue, so that it doesn't pull the data directly from VRMS. However, it would be helpful to have a page so that we can visually test the VRMS data when we need to. So should we increase the scope of this issue to make a copy of the current events page and call it events-check so that we can use it much like we use the projects-check page (a different view on the data that makes it easy to do manual verification). Later, we can strip anything off the page that we don't need.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @irais-valenzuela, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability for this week: Wednesday - Friday |
@irais-valenzuela I will move this issue to the in progress column, in the future, please remember to do that after you self assign. |
Availability for this week: Monday, Thursday, & Friday |
@irais-valenzuela in answer to your question - if you search for the variable |
@roslynwythe Thanks this is helpful! Is the idea to replace the API request made on ./utility/api-events.js to get meeting data for the right-col-content.html page with the vrmsData retrieval used in projects to get meeting data? |
Yes, exactly. It is inefficient to make API calls to VRMS when the meeting data has already been retrieved and stored into |
Progress: I figured out what code can be shared between both event.js and project.js. I'm currently familiarizing myself with Jekyll and Liquid to figure out how to get data using liquid. Will continue working next week 4/29-5/3 |
Overview
We need to refactor the JavaScript that generates the list of meetings on the Events page, so that it retrieves meeting data from the file
data/external/vrms_data.json
, in order to reduce the latency and improve the reliability of the Events page. For testing purposes, a new pageevents-check
will be created that will maintain the behavior of the currentevents
page.Details
The project pages currently sources meeting data from
data/external/vrms_data.json
and so elements of that code can be refactored so that functions can be called from the Events page as well.Action Items
events.html
then rename the copy toevents-check.html
and change the permalink to/events-check
events.js
then rename the copyevents-check.js
and updateevents-check.html
to reference the renamed file_includes/events-page/right-col-content.html
then rename the copy to_includes/events-page/right-col-content-check.html
and updateevents-check.html
to reference the renamed fileassets/js/right-col-content.js
then rename the copyassets/js/right-col-content-check.js
and modify_includes/events-page/right-col-content-check.html
to reference the renamed file/events-check
are identical to/events
assets/js/project.js
in your IDE and understand the code used to display project meetings. If there is code that can be shared between the project and events pages, move those elements to a new fileassets/js/utility/vrms-events.js
.assets/js/utility/vrms-events.js
, refactor the code inassets/js/project.js
to reference function(s) in the new file, and perform testing to confirm that functionality on the Project page1 is unchanged.assets/js/right-col-content.js
and_includes/events-page/right-col-content.html
to reference the function(s) inassets/js/utility/vrms-events.js
and perform testing to confirm that functionality on the Event page2 is unchanged.Resources/Instructions
Merge Team
Footnotes
Project page - sample ↩
Events webpage ↩
The text was updated successfully, but these errors were encountered: