Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolkit yml files to include a new fields #3357

Closed
4 tasks done
ExperimentsInHonesty opened this issue Jul 11, 2022 · 16 comments · Fixed by #3431
Closed
4 tasks done

Update toolkit yml files to include a new fields #3357

ExperimentsInHonesty opened this issue Jul 11, 2022 · 16 comments · Fixed by #3431
Assignees
Labels
Complexity: Medium P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Milestone

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jul 11, 2022

Overview

We need to add new fields and change a field to the Internal and External Resources files for the toolkit, so that we can have filters similar to what exists on the homepage.

Action Items

  • Add the field to all files listed below
  • identify which files need info for the new fields and add them to a comment on this issue, so that the Guides team can provide the information. Bring this to Sunday meeting with product.
  • Change the name of category and update the code that displays the toolkit page results when you click on Development on the ribbon menu
  • update wiki template example (created this one)

Resources/Instructions

Additional Fields needed

tools (Figma, GitHub, Miro, etc.)
contributors (for internal guides all contributors will be listed)
source (Hack for LA, Code for America, Other)

Change the name of these fields

from category to practice-area

Current Fields for items showing up on the https://www.hackforla.org/toolkit/ as External Resources

title: Figma
  description: Our design team uses Figma to create wireframes and mockups.
  svg: svg/icon-figma.svg
  link-svg: svg/outer-link.svg
  provider-link: 'https://www.figma.com/'
  display: true

Current Fields for items showing up on the https://www.hackforla.org/toolkit/ as Guides

title: 2FA Guide
description: Hack for LA requires two-factor authentication (2FA) in GitHub for all project contributors.
short-description: Hack for LA requires two-factor authentication (2FA) in GitHub for all project contributors.
in-this-guide:
  - name: To Enable 2FA
    link: '#To-Enable-2FA'
  - name: FAQ
    link: '#FAQ'
card-type: guide-page
status: active
display: true
category: Development
svg: svg/2FA.svg
provider-link: '/guide-pages/2FA'
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jul 11, 2022
@ExperimentsInHonesty ExperimentsInHonesty added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Toolkit https://www.hackforla.org/toolkit/ size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jul 11, 2022
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Jul 11, 2022
@ExperimentsInHonesty ExperimentsInHonesty changed the title Update toolkit yml files to include a toolkit field Update toolkit yml files to include a toolkit and type field Jul 11, 2022
@ExperimentsInHonesty ExperimentsInHonesty changed the title Update toolkit yml files to include a toolkit and type field Update toolkit yml files to include a new fields Jul 15, 2022
@tunglinn tunglinn self-assigned this Jul 16, 2022
@github-actions
Copy link

Hi @tunglinn, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@tunglinn
Copy link
Member

Availability: M-Th 6 hours/day
ETA: 7/21

@tunglinn
Copy link
Member

tunglinn commented Jul 17, 2022

2FA

  • Tools
    • GitHub
  • Contributors
    • Danielle Nedivi
    • Ruben Sanchez
  • Source: Hack for LA?
  • Recommended By:

Creating Kanban projects - "Create a Guide/Template: Agile Development/Scrum/Kanban"

  • Tools
    • Kanban
  • Contributors
    • Qiqi Zheng
  • Source: Hack for LA
  • Recommended By:

Figma for open source projects - "Creating a Figma account for your project"

  • Tools
    • Figma
  • Contributors
  • Source: Hack for LA
  • Recommended By:

Found some other guides that can fall in this category too? Effective practices, For teams

GitHub issues (Guide in HfLA Google Drive)

  • Tools
    • GitHub
  • Contributors
    • Danielle Nedivi
    • Bonnie Wolfe
  • Source: Hack for LA
  • Recommended By:

Responsible use of images in open source projects (Guide in HfLA Google Drive)

Setting up 1password on open source projects

  • Tools
    • 1Password
  • Contributors
    • Jessica Cheng
  • Source: Hack for LA
  • Recommended By:

Showing civic tech experience on linkedin

  • Tools
    • LinkedIn
  • Contributors
    • Ibraheem Agbaje
    • Bonnie Wolfe
  • Source: Hack for LA
  • Recommended By:

Survey reporting dashboard guide

  • Tools
    • Google Data Studio
  • Contributors
    • Harish Lingam
    • Danielle Nedivi
    • Hannah Livnat
  • Source: Hack for LA
  • Recommended By:

Update teams page on hfla site

  • Tools
    • GitHub
    • VSCode
  • Contributors
  • Source: Hack for LA
  • Recommended By:

Using Kanban project (hackforla/knowledgebase-content#16)

  • Tools

    • Kanban
  • Contributors
    Alexandra Stubbs, Alabi Kayode, Bonnie Wolfe, Leroy Tung, Tarang Gupta, Pawan Murthy, Ahdithan Uthayakumar Tarang Gupta, Ashley Lin, Dani N, Johan Suh, Liyang Chen

  • Source: Hack for LA

  • Recommended By:

@tunglinn
Copy link
Member

tunglinn commented Jul 17, 2022

Finding guides information:

@tunglinn
Copy link
Member

tunglinn commented Jul 17, 2022

Here are the guides that need to be checked/clarified.

2FA: source? HfLA or Other (GitHub)

Creating Kanban projects - "Create a Guide/Template: Agile Development/Scrum/Kanban" VS Using Kanban project (hackforla/knowledgebase-content#16)

Figma for open source projects
Is this the right link?
Because I found some other guides that could fall in this category too? Effective practices, For teams, Creating account

Responsible use of images in open source projects (Guide in HfLA Google Drive)

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Jul 19, 2022

delete the following fields and content from the files in this folder: https://github.com/hackforla/website/tree/gh-pages/_guide-pages

"short description"

In the file: https://github.com/hackforla/website/blob/gh-pages/_includes/guide-card.html

change from

            {%- if guide.short-description -%}
            <p>{{ guide.short-description }}</p>
            {%- endif -%}

change to

            {%- if guide.description -%}
            <p>{{ guide.description }}</p>
            {%- endif -%}

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Jul 19, 2022

change the status of all coming soon's to be Work in Progress, change the active to be Completed in the files in this folder: https://github.com/hackforla/website/tree/gh-pages/_guide-pages

In the file: https://github.com/hackforla/website/blob/gh-pages/_includes/guide-card.html

change from

        {%- if guide.status == 'coming-soon' -%}
            <span class="toolkit-flex-item-status">coming soon</span>
        {%- endif -%}  

to

[your code here]


This code will have to check for status==completed and give the link if it is completed and not if its not.

       {%- if guide.status == 'coming-soon' -%}
                <h3>{{ guide.title }}</h3>
            {%- else -%}  
                {%- if guide.title -%}
                <h3><a href={{ item.provider-link }}>{{ guide.title }}</a></h3>
                {%- endif -%}
            {%- endif -%}

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Jul 19, 2022

Here is the complete list of fields that should be available when done (replacement name is in parens)

title:
description:
image:
provider-link (resource-url)
display:
card-type:
category (practice-areas):
status:

recommended-by
tools
contributors
source

@tunglinn
Copy link
Member

tunglinn commented Jul 20, 2022

Also, figure out svg vs link-svg.

link-svg is the bottom right icon for external resources.

Action items:

  • deleted link-svg from toolkitresources.yml
  • every external resource will have the same bottom right icon (made this change in toolkit.html

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Jul 22, 2022
@tunglinn
Copy link
Member

New Wiki Template page can be found here: https://github.com/hackforla/website/wiki/Toolkit-files-template

@tunglinn
Copy link
Member

All changes are done.

One little blocker: I've changed the code so the practice area also filters for External Resources. However, the External Resource cards are in a special container (guides don't have one), that centers the External Resource card.

Take a look.

image

While the guide cards on top are shifted left.

image

@tunglinn
Copy link
Member

Removed container (external-resource-container) that shifted External Resources to the left.

According to PR #1999, the container was created to match the design in Figma. When I checked Figma, that design no longer exists. Also, the current design team has been reworking the toolkit page.

I also consulted Bonnie for the decision to remove external-resource-container.

@tunglinn
Copy link
Member

tunglinn commented Aug 9, 2022

Add
resource-url-completed:
resource-url-wip:
resource-url-depreciated:

resource-url-wip link at "work in progress" if status is work-in-progress.

Other details will be settled at Friday's guide meeting (8/12/2022)

@tunglinn
Copy link
Member

tunglinn commented Aug 15, 2022

Revert changes with description and short-description in each guide file. The variable description is currently being used on the actually guide page, but the new system will have it all in the markdown file from the converter.

Create new system that will use description if short enough (will have to define this), otherwise use short-description.
The guide card adjusts to the size of the description, so I decided to cap it at 210 characters. This can be changed in guide-card.html.

We should also have a system that reminds us that the short-description is missing. However, since it seems like right now, guide cards are being created manually, I'll just mention it in the wiki template page.

@tunglinn
Copy link
Member

On the current Toolkit page, the titles of completed vs in progress guide cards are not aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
2 participants