Auth code2 #234
Auth code2 #234
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@ethanstrominger For the pre-commit hooks that gave you errors, it looks like it's just something to do with your particular system environment or macOS. I added them back and the automated pre-commit checks are all still passing. Like we discussed, you can skip hooks by setting SKIP environment variable like |
| @@ -12,6 +12,6 @@ then | |||
| fi | |||
|
|
|||
| # python manage.py flush --no-input | |||
| # python manage.py migrate | |||
| python manage.py migrate | |||
There was a problem hiding this comment.
It's not necessary to run this since the buildrun.sh script also calls migrate (actually in the run.sh that it calls)
| ``` | ||
| brew install pre-commit | ||
| ``` |
There was a problem hiding this comment.
Indent this block 1 more space to the right to put it "within" the numbered list item. Otherwise, markdown treats this as another object at the same level and tthe next number starts at 1 again like below.
| Docker, do the following steps. WARNING: If you run into issues you will get limited support. | ||
|
|
||
| Run these commands from the app directory: | ||
| 1. From the terminal: |
There was a problem hiding this comment.
Need to add a blank line before the numbered list so that 1. shows up in a separate line. There's a few things that got changed when I ran mdformat locally. I can commit the changes if you're okay with it.
| @@ -25,4 +25,4 @@ These scripts assume you are using bash. | |||
|
|
|||
| 1. **createsuperuser.sh** - creates a default superuser. | |||
|
|
|||
| 1. This assumes that `DJANGO_SUPERUSER_USERNAME` and `DJANGO_SUPERUSER_PASSWORD` are set in `.env.dev` | |||
| 1. This assumes that `DJANGO_SUPERUSER_USERNAME` and `DJANGO_SUPERUSER_PASSWORD` are set in `.env.docker` | |||
There was a problem hiding this comment.
So it's .env.docker and .env.local. Eventually we could have a .env.production, which also uses docker. We'll think about that when we get there.
docs/how-to/run-local.md
Outdated
| 3. From the terminal in the app directory, run: | ||
| ``` | ||
| source ../scripts/setscriptpath.sh | ||
| source start-local.sh |
There was a problem hiding this comment.
When I ran this I got an error message about not finding the file. I checked that the script path is in $PATH
There was a problem hiding this comment.
If I ran ../scripts/start-local.sh it complains about loadenv.sh not found.
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied