Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Audit differences between code and documented field names #432

Open
4 tasks
Neecolaa opened this issue Nov 8, 2024 · 3 comments
Open
4 tasks

Epic: Audit differences between code and documented field names #432

Neecolaa opened this issue Nov 8, 2024 · 3 comments
Assignees
Labels
complexity: large Many parts are unexplained and up to the implementer to figure out. feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: update table role: db architect role: product s: PD team stakeholder: People Depot Team size: 2pt Can be done in 7-12 hours

Comments

@Neecolaa
Copy link
Member

Neecolaa commented Nov 8, 2024

Overview

There are field names in the code that do not currently match our documentation. We need to go through the existing django models, identify the mismatches, and update the code or documentation to comply with our desired naming conventions.

Action Items

  • List existing models
  • For each model, create a table containing the different field names
  • Verify desired naming conventions
  • Update the documentation/code

Resources/Instructions

1.01 Code locations

1.02 People Depot Resources wiki page for links

@Neecolaa Neecolaa added role: missing size: missing s: PD team stakeholder: People Depot Team draft This issue is not fully-written feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: update table complexity: missing labels Nov 8, 2024
@Neecolaa Neecolaa added this to the v0.01. Initial Setup milestone Nov 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕New Issue Review in P: PD: Project Board Nov 8, 2024
@fyliu
Copy link
Member

fyliu commented Nov 8, 2024

I want to note that when we name a ForeignKey field something like "user", Django will create a database column called "user_id". It's Django's convention to drop the "_id" from the end when converting from db to Django code.

These screenshots illustrate how ForeignKey fields in Django actually turn into db columns with "_id" endings
Image
Image

I can find a link to a better description of this when I'm on a computer.

@shmonks shmonks moved this from 🆕New Issue Review to 🏗In progress-actively working in P: PD: Project Board Nov 15, 2024
@shmonks shmonks removed the draft This issue is not fully-written label Nov 15, 2024
@shmonks shmonks added complexity: large Many parts are unexplained and up to the implementer to figure out. role: db architect role: product size: 2pt Can be done in 7-12 hours and removed complexity: missing role: missing size: missing labels Nov 15, 2024
@Neecolaa
Copy link
Member Author

event has a field called brigade_id that's commented out, but will need to be changed to org_id

@shmonks
Copy link
Member

shmonks commented Nov 22, 2024

Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: large Many parts are unexplained and up to the implementer to figure out. feature: ERD/SS adjustment Requires adjustments to be made to the ERD & Spreadsheet feature: update table role: db architect role: product s: PD team stakeholder: People Depot Team size: 2pt Can be done in 7-12 hours
Projects
Status: 🏗In progress-actively working
Development

No branches or pull requests

4 participants