Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new iam user for self @here #92

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

here
Copy link
Member

@here here commented Nov 25, 2024

Fixes #77

What changes did you make?

Why did you make the changes (we will use this info to test)?

Copy link

Terraform plan in terraform
With backend config files: terraform/prod.backend.tfvars

Plan: 3 to add, 2 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place

Terraform will perform the following actions:

  # module.iam_oidc_gha_incubator.aws_iam_role.github_actions_oidc will be updated in-place
!~  resource "aws_iam_role" "github_actions_oidc" {
!~      assume_role_policy    = jsonencode(
!~          {
!~              Statement = [
!~                  {
!~                      Condition = {
!~                          StringLike   = {
!~                              "token.actions.githubusercontent.com:sub" = "*************************************************************************"
                            }
#                            (1 unchanged attribute hidden)
                        }
#                        (3 unchanged attributes hidden)
                    },
                ]
#                (1 unchanged attribute hidden)
            }
        )
        id                    = "gha-incubator"
        name                  = "gha-incubator"
        tags                  = {}
#        (11 unchanged attributes hidden)
    }

  # module.iam_user_alexe.aws_iam_user_group_membership.user_group_membership will be updated in-place
!~  resource "aws_iam_user_group_membership" "user_group_membership" {
!~      groups = [
-           "ops-leads",
+           "read-only-group",
        ]
        id     = "terraform-20240815021728326500000001"
#        (1 unchanged attribute hidden)
    }

  # module.iam_user_herehfla.aws_iam_user.user will be created
+   resource "aws_iam_user" "user" {
+       arn           = (known after apply)
+       force_destroy = false
+       id            = (known after apply)
+       name          = "herehfla"
+       path          = "/"
+       tags          = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       tags_all      = {
+           "Access Level" = "1"
+           "Project"      = "devops-security"
        }
+       unique_id     = (known after apply)
    }

  # module.iam_user_herehfla.aws_iam_user_group_membership.user_group_membership will be created
+   resource "aws_iam_user_group_membership" "user_group_membership" {
+       groups = [
+           "read-only-group",
        ]
+       id     = (known after apply)
+       user   = "herehfla"
    }

  # module.iam_user_herehfla.aws_iam_user_login_profile.user_login will be created
+   resource "aws_iam_user_login_profile" "user_login" {
+       encrypted_password      = (known after apply)
+       id                      = (known after apply)
+       key_fingerprint         = (known after apply)
+       password                = (known after apply)
+       password_length         = 20
+       password_reset_required = true
+       user                    = "herehfla"
    }

Plan: 3 to add, 2 to change, 0 to destroy.

📝 Plan generated in Write Terraform Plan to Pull Request #63

@@ -149,7 +149,7 @@ module "iam_user_alexe" {
"Project" = "devops-security"
"Access Level" = "1"
}
user_groups = ["ops-leads"]
user_groups = ["read-only-group"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user_groups = ["read-only-group"]
user_groups = ["ops-leads"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @here this needs to be its original value of 'ops-leads'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-work Checklist: DevOps-Security-Member: Mike Waggoner
2 participants