Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate Google drive, but not sure how to use custom error msg #1526

Closed
wants to merge 1 commit into from

Conversation

evanyang1
Copy link
Member

Fixes #1369
(Sort of)

What changes did you make and why did you make them ?

  • Add validate function to data.js for google drive field
  • Add validate field to register object

!! I didn't find out how to do a custom error message.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b hackforla-evan1369 development
git pull https://github.com/hackforla/VRMS.git evan1369

@JackHaeg
Copy link
Member

FYI - the requirement to validate Google Drive has changed since this PR was delivered, and this function will likely be dropped. I will confirm with the stakeholder tomorrow and update/close this PR pending approval.

@trillium
Copy link
Member

@JackHaeg Looking to resolve this, did we get confirmation on this requirement?

@JackHaeg
Copy link
Member

JackHaeg commented Sep 9, 2024

@trillium & @evanyang1 Per discussion with stakeholder, Google Drive URL is a required field. So, this PR is still relevant and this fix is necessary.

However, we ask that prior to merging, please update the custom error message to read "Invalid URL". Once this custom error message is in place, please feel free to merge this PR if it meets all other acceptance criteria. Plan to discuss during today's All Team MTG call.

@JackHaeg
Copy link
Member

JackHaeg commented Sep 9, 2024

@trillium Can you please provide Evan with some assistance on how to create this custom error message ("Invalid URL")?

@JackHaeg
Copy link
Member

@evanyang1

  • Confirmed with stakeholder that this is a required field and that the error message needs to be updated to "Invalid URL". In short:
  • Existing Requirements = validated as a Google Drive URL
  • NEW Requirements:
    • The Google Drive URL field itself is required to be filled out in order to save edits on an existing project / create a new project (Google Drive URL = REQUIRED field)
    • If the Google Drive URL is not validated, error message should read "Invalid URL"

Plan for this PR:

  • Before merging, please submit a new PR with the following additional requirements:
    • Make Google Drive URL field a required field. (error message when field is left unfilled = "Google Drive URL is required")
    • Update Validation Error message to "Invalid URL" (i.e., when user enters a URL other than a Google Drive URL)

@jbubar jbubar closed this Sep 24, 2024
@jbubar
Copy link
Member

jbubar commented Sep 24, 2024

This is a good start and could potentially be used by the next person who picks up #1369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation - Google Drive URL
4 participants