Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation - Event Link #1491

Conversation

StephenTheDev1001
Copy link
Contributor

@StephenTheDev1001 StephenTheDev1001 commented Aug 29, 2023

Fixes #1364

What changes did you make and why did you make them ?

  • added validation for videoConferenceLink, so that users know what to insert into the field and inputs are uniform across all projects.
  • created a function containsHttps to check if videoConferenceLink includes https://
  • created a function containsZoomOrGMeet to check if videoConferenceLink includes zoom.us or meet.google.com/
  • added error messages Your link must start with https:// and This does not look like a valid Zoom or Google Meet link

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Currently unable to test

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b StephenTheDev1001-form-validation-event-link-1364 development
git pull https://github.com/StephenTheDev1001/VRMS.git form-validation-event-link-1364

@StephenTheDev1001 StephenTheDev1001 added the draft Not ready for prioritization yet label Aug 29, 2023
@StephenTheDev1001 StephenTheDev1001 changed the title initial commit Form Validation - Event Link Aug 29, 2023
@StephenTheDev1001
Copy link
Contributor Author

Already being done #1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Not ready for prioritization yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation - Event Link
1 participant