-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable form #1471
Reusable form #1471
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I've left a few requests for changes, please update those and then we'll get it merged!
Feel free to do these things a different way if you see fit, but I updated the code to revert to prev state on 2nd Edit button click, and added back in the Manually Triggered Event Checkin section here: |
This comment was marked as outdated.
This comment was marked as outdated.
Pull request add a few more tasks which is now complete:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stoked on these changes!
Fixes #1470
What changes did you make and why did you make them ?
Additional comments
Edit project page validation needs to be updated to read current project details on the Edit Page. The validation isn't picking up the passed values for the project info and returns a validation error when you try to save. It does however, remove the highest error, one by one, if you continue to save. Eventually they all clear and the save submits.api/ProjectServiceApi/create
. It is currently handling a POST request and returning the project ID. I believe these should be separate functions since they serve different purposes.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Before
After