Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Header redesigns #1846

Open
3 of 4 tasks
ryanfchase opened this issue Oct 19, 2024 · 2 comments · May be fixed by #1871
Open
3 of 4 tasks

Dev: Header redesigns #1846

ryanfchase opened this issue Oct 19, 2024 · 2 comments · May be fixed by #1871
Assignees
@bphan002
Labels
Complexity: Small P-Feature: Header Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Milestone
06 - Product Main...

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Oct 19, 2024 •
edited by bphan002
Loading

Overview

We need to update the header so that it uses images that indicate we are in the city of Los Angeles.

Action Items

  • Download the target image from Figma
    • Don't simply use the address url from the issue: we don't know if github issues will compress the image
  • Commit the image to the assets folder
  • EITHER
    • use CSS to apply this image as a background-image to the headingBackground class styles
    • modify opacity for headingBackground to match designer's spec
  • OR
    • supply an <img> element within the TextHeading component
    • create and apply new styles to that <img> element

Resources/Instructions

Useful files:

  • components/common/TextHeading/index.jsx
  • components/common/TextHeading/TextHeadingFAQ.jsx

Design Resources

Screenshot before proposed changes

[insert screenshot here]

Screenshot after proposed changes

[insert screenshot here]

@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Oct 19, 2024
@ryanfchase
Copy link
Member Author

This ticket is ready for picking up

This was referenced Oct 19, 2024
Closed
Open
@bphan002 bphan002 self-assigned this Nov 9, 2024
@bphan002 bphan002 moved this from Prioritized Backlog to In progress in P: 311: Project Board Nov 9, 2024
@bphan002
Copy link
Member

bphan002 commented Nov 9, 2024

ETA Monday Nov 11 EOD

@bphan002 bphan002 linked a pull request Nov 23, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bphan002 bphan002

Labels
Complexity: Small P-Feature: Header Role: Frontend React front end work size: 0.50pt Can be done in 3 hours
Projects
P: 311: Project Board
Status: In progress
Milestone
06 - Product Maintenance
Development

Successfully merging a pull request may close this issue.

1846 redesign header bphan002/311-data
2 participants
@ryanfchase @bphan002