Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding summary slide does not work if presentation contains exportable text area #147

Open
fkohrt opened this issue Dec 30, 2020 · 12 comments

Comments

@fkohrt
Copy link

fkohrt commented Dec 30, 2020

If a presentation contains an exportable text area, hiding the summary slide does not work.

Tried with exportable-text-area.zip at einstiegh5p.de.

@otacke
Copy link
Contributor

otacke commented Dec 30, 2020

@fkohrt I have never used exportable text areas and can confirm the behavior - but since the button for exporting the text seems to be on the summary slide, what is it that you are feeling is wrong with the behavior?

@fkohrt
Copy link
Author

fkohrt commented Dec 30, 2020

  1. If a user chooses to hide the summary slide, the checkboxes that control the visibility of the buttons Show solutions and Retry become hidden as well -- despite the buttons still being displayed.
  2. The behaviour contradicts what the option to hide the summary slide promises: There is no effect.

I can think of two solutions:

  1. Don't allow to hide the summary slide if presentation contains an exportable text area.
  2. Make visibility of Export text button configurable as well and actually hide the summary slide if the user chooses to.

@otacke
Copy link
Contributor

otacke commented Dec 30, 2020

@fkohrt Much clearer issue already, thanks!

  • problem 1) If you don't want these buttons, you can deactivate them before checking the button to hide the summary slide.

  • problem 2) Unfortunately, there will always be exceptions to rules, and I personally think ingnoring the setting instead of rendering the exportable text area useless is good justification for showing the summary slide.

  • suggestion 1) Sounds reasonable (and could be simple to do, not 100 % sure), but may lead to more confusion ("Why the heck can't I hide the summary slide now") that would then have to be tackled as well, at least with amending the description text of that field.

  • suggestion 2) How would you then suggest to export the text of the exportable text areas?

I am not aware how often the exportable text areas are used actually, so I am not sure whether adding complexity to resolve the current behavior that may be an edge case would really be beneficial.

@fkohrt
Copy link
Author

fkohrt commented Dec 30, 2020

suggestion 2) How would you then suggest to export the text of the exportable text areas?

I am new to H5P and couldn't verify so far but I imagined that the text is stored alongside other "results" (such as scores) on the server. If that's not possible then the exportable text area is of course useless without that button. Suggestion 1 would still make sense to me in that case, but of course I imagine there are issues more worthy of dev time.

@otacke
Copy link
Contributor

otacke commented Dec 30, 2020

@fkohrt Not all platforms that H5P runs on have some form of gradebook (like moodle), so I don't think it's optional. And yes, suggestion 1 would probably be possible although it may require some uncommon tinkering with the editor. It's not up to me to decide anyway ;-)

Please continue to share your ideas! If I may suggest to use the forum at https://h5p.org/forum however? I think it's better suited, because most people (well, the total number is still small) discuss feature suggestions there.

@fkohrt
Copy link
Author

fkohrt commented Dec 30, 2020

Please continue to share your ideas! If I may suggest to use the forum at https://h5p.org/forum however? I think it's better suited, because most people (well, the total number is still small) discuss feature suggestions there.

I will, thank you! Maybe expanding the Getting Involved page on h5p.org to a full CONTRIBUTING.md might help newcomers to understand how the H5P community works :)

@otacke
Copy link
Contributor

otacke commented Dec 30, 2020

@fkohrt There's definitely room for improvement in that regard, yes.

@fkohrt
Copy link
Author

fkohrt commented Dec 30, 2020

And I just realized that the Contributing page comes very close to what I meant, didn't notice it before.

@otacke
Copy link
Contributor

otacke commented Dec 31, 2020

@fkohrt Being German, you'll find more "beyond using" information at https://www.oercamp.de/webinare/h5pmaig/ and, for coding in particular, at https://www.youtube.com/playlist?list=PL4lOawnmqTnHuQIBYz7K7LkdTybL3Ui7T

@fkohrt
Copy link
Author

fkohrt commented Dec 31, 2020

Cool, thanks!

@Urpokarhu1
Copy link

Urpokarhu1 commented Jun 25, 2024

Hello,

There is a bug with exportable text area -element in course presentation. When you have a blank course presentation > you add exportable text area > save and display > you navigate to the last page it now contains three buttons

  • View solutions
  • Try again
  • Export text

and there should be only one button "export text"

  • Tested with
  • Moodle 4.1
  • mod_hvp 1.26.1
  • Course Presentation (1.25.31)
  • Course Presentation Editor (1.25.9)
  • Exportable Text Area (1.3.17)

h5p1
h5p2
h5p3

@Urpokarhu1
Copy link

Urpokarhu1 commented Jun 25, 2024

Nevermind I just noticed
"problem 1) If you don't want these buttons, you can deactivate them before checking the button to hide the summary slide."

#147 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants