-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building with hotscript as dependency #80
Comments
It's indeed really weird. |
@ecyrbe The output did change a bit, but somehow to the worse: now it also includes direct imports from hotscript's I updated the project to have |
Can you try but making HOTScript a peerdependency ? |
TSUP will include a dep sometimes, even if its only a dev dep but is not marked as a peer dep. |
Similar use case here - have buildable library within NX workspace which I may want to publish for other consumers, the types are mess as well. |
Hey there! Thanks for the repo, it's very nice, just as your course (passed it and liked a lot!).
We at Evil Martians have plans to extend our nanostores ecosystem with a form library called nanoform. And for it we wanted to make a map store that will provide typesafe object path interface for the underlying structure. That's where we use
Objects.Get
andObjects.AllPaths
utilities.It works perfectly from the DX point of view, but we have an issue when building the lib. It's probably not hotscript specific, but I hoped you could give any guidance on how to fix that.
Here's a repro on StackBlitz. You need to run
npm run build
in terminal there. See the problem is that tsc inlines a lot of hotscript code in the.d.ts
file making it unreadable mess.What's extremely odd is that it does that for one function,
getPath
, but not the other,setPath
, even though both use the same set of utility types. Do you have any idea how to get rid of this? Thanks!The text was updated successfully, but these errors were encountered: