fix: bufferFrom

README.md

@@ -100,8 +100,8 @@ Latest results:
 ┌─────────┬────────────────┬───────────┬────────────────────┬──────────┬─────────┐
 │ (index) │ Task Name      │ ops/sec   │ Average Time (ns)  │ Margin   │ Samples │
 ├─────────┼────────────────┼───────────┼────────────────────┼──────────┼─────────┤
-│ 0       │ 'gmatch'       │ '287,789' │ 3474.757510684889  │ '±0.33%' │ 719475  │
-│ 1       │ 'streamsearch' │ '280,600' │ 3563.7901000848046 │ '±0.26%' │ 701501  │
+│ 0       │ 'gmatch'       │ '320,020' │ 3124.7951309445925 │ '±0.89%' │ 1600105 │
+│ 1       │ 'streamsearch' │ '285,266' │ 3505.4937444482543 │ '±0.18%' │ 1426333 │
 └─────────┴────────────────┴───────────┴────────────────────┴──────────┴─────────┘
 gmatch matches: 12
 streamsearch matches: 12

src/index.js

@@ -1,11 +1,7 @@
-const bufferFrom = (string) => {
-  const buffer = new Uint8Array(string.length);
-
-  for (let i = 0; i !== string.length; ++i) {
-    buffer[i] = string.charCodeAt(i);
-  }
+const textEncoder = new TextEncoder();
 
-  return buffer;
+const bufferFrom = (string) => {
+  return textEncoder.encode(string);
 };
 
 const bufferCompare = (buffer1, offset1, buffer2, offset2, length) => {
@@ -35,6 +31,10 @@ export const Match = class {
    * @throws {RangeError}
    */
   constructor(pattern, callback, from = bufferFrom) {
+    if (typeof from !== "function") {
+      throw new TypeError("From must be a Function");
+    }
+
     if (typeof callback !== "function") {
       throw new TypeError("Callback must be a Function");
     }
@@ -69,7 +69,11 @@ export const Match = class {
 
   write(chunk) {
     const buffer =
-      chunk instanceof Uint8Array ? chunk : this.#from(String(chunk));
+      chunk instanceof Uint8Array
+        ? chunk
+        : chunk instanceof ArrayBuffer || ArrayBuffer.isView(chunk)
+          ? new Uint8Array(chunk)
+          : this.#from(String(chunk));
     let offset = 0;
 
     while (offset !== buffer.length) {

test/index.js

@@ -8,6 +8,12 @@ test("Match constructor should create a Match instance with valid input", () =>
   assert(match instanceof Match);
 });
 
+test("Match constructor should throw TypeError for non-function from", () => {
+  assert.throws(() => {
+    return new Match("test", () => {}, "not a function");
+  }, TypeError);
+});
+
 test("Match constructor should throw TypeError for non-function callback", () => {
   assert.throws(() => {
     return new Match("test", "not a function");
@@ -352,3 +358,29 @@ test("pattern test /4", (t, done) => {
   assert.strictEqual(c, 1);
   done();
 });
+
+test("pattern test /5", (t, done) => {
+  let c = 0;
+
+  const m = new Match("Hello, World!", () => {
+    c++;
+  });
+
+  m.write(new ArrayBuffer("Hello, World!".length));
+
+  assert.strictEqual(c, 1);
+  done();
+});
+
+test("pattern test /5", (t, done) => {
+  let c = 0;
+
+  const m = new Match("Hello, World!", () => {
+    c++;
+  });
+
+  m.write(new ArrayBuffer("Hello, World!".length));
+
+  assert.strictEqual(c, 1);
+  done();
+});