Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPGRADE]: android gradle to 4.0.1 and gradle to 6.1.1 #246

Open
1 of 3 tasks
tuantvu opened this issue Apr 13, 2021 · 4 comments
Open
1 of 3 tasks

[UPGRADE]: android gradle to 4.0.1 and gradle to 6.1.1 #246

tuantvu opened this issue Apr 13, 2021 · 4 comments
Assignees
Labels
backlog Added to the backlog chore Upgrade dependencies

Comments

@tuantvu
Copy link
Collaborator

tuantvu commented Apr 13, 2021

Dependency Information
Name: gradle-wrapper.properties
Version: distributionUrl=https://services.gradle.org/distributions/gradle-6.1.1-all.zip
Name: build.gradle
Version: dependencies {
classpath 'com.android.tools.build:gradle:4.0.1'
}
Platform

  • Android
  • iOS
  • Web

Reason for upgrade

Conform to official Jitsi meet example

Provide additional context

https://github.com/jitsi/jitsi-meet-sdk-samples/tree/master/android/java/JitsiSDKTest

@tuantvu tuantvu added the chore Upgrade dependencies label Apr 13, 2021
@tuantvu tuantvu self-assigned this Apr 13, 2021
@tuantvu tuantvu added the backlog Added to the backlog label Apr 13, 2021
@aliyazdi75
Copy link

Hi @tuantvu
Because of some dependencies like org.jitsi.meet.sdk.ConnectionService, org.jitsi.meet.sdk.JitsiMeetOngoingConferenceService and org.jitsi.meet.sdk.JitsiMeetActivity, android:exported hasn't been mentioned in their activity or service, we can't run the project for android API 31 and getting this error:
Manifest merger failed : android:exported needs to be explicitly specified for <service>. Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

When do you think it will be updated to the new versions of dependencies?

@aliyazdi75
Copy link

I could solve this issue by adding this to our manifest:

        <service android:name="org.jitsi.meet.sdk.ConnectionService"
            android:exported="false"
            tools:node="merge" />

But it would be better to solve this by the package.

@ektapadaliya
Copy link

@aliyazdi75
Where to add on manifest ?

@aliyazdi75
Copy link

@aliyazdi75 Where to add on manifest ?

under application tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Added to the backlog chore Upgrade dependencies
Projects
None yet
Development

No branches or pull requests

3 participants