Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated cards misplace translations into wrong columns #29

Open
deleuzei opened this issue Jan 6, 2022 · 3 comments
Open

Autogenerated cards misplace translations into wrong columns #29

deleuzei opened this issue Jan 6, 2022 · 3 comments

Comments

@deleuzei
Copy link

deleuzei commented Jan 6, 2022

Hello, I'm trying to autogenerate cards from English to French. I've set the lang field in cards_config.json

					"id": "29b15499-d339-4b1c-8b31-2d7466a29a2b",
					"name": "French Vocabulary - English to French",
					"src": 
					[
						{
							"type": "autogenerate",
							"file": "words.txt",
							"card_color": "#33AA33",
							"show_tags": true,
							"card_properties": 
							{
							"tags": ["french", "vocabulary", "autogenerated"]
							},
							"header": false,
							"pronunciation_in_reverse": false,
							"lang": 
							{
								"original": "en",
								"translation": "fr"
							},
							"one_translation": false,
							"audio": true
						}         
					]

The words.txt file contains three words in English

car
January
Monday

The translations generated by mnemocards generate and mnemocards maketsv place the generated translations in wrong columns:

ID	YourLanguageWord	YourLanguageExplanation	LanguageYouLearnWord	LanguageYouLearnPronunciation	LanguageYouLearnExplanation	Tags
0c452564-88b7-c86e-8906-bdc1d505d5cd	janvier		January	ˈjanyəˌwerē	<div class="definitions"><div class="speechpart">Nom</div><div class="line_1">the first month of the year, in the northern hemisphere usually considered the second month of winter.</div><div class="line_2">Sophie was two in January</div></div>	
1d686100-a3c0-c2c2-1d12-663c8e92706e	auto	<div class="synonyms"><div class="speechpart">Nom</div><div class="line_1">voiture</div><div class="line_2">['car', 'vehicle', 'carriage', 'coach', 'wagon', 'motor']</div><div class="line_1">car</div><div class="line_2">['car', 'bus', 'motor']</div><div class="line_1">wagon</div><div class="line_2">['car', 'wagon', 'coach', 'waggon', 'waggonload']</div></div>	car	kär	<div class="definitions"><div class="speechpart">Nom</div><div class="line_1">a four-wheeled road vehicle that is powered by an engine and is able to carry a small number of people.</div><div class="line_2">she drove up in a car</div></div>	
3c672ad7-8386-4ba3-29f9-1a0c5ca17138	Lundi	<div class="synonyms"><div class="speechpart">Nom</div><div class="line_1">lundi</div><div class="line_2">['Monday']</div><div class="line_1">le lundi</div><div class="line_2">['Monday']</div></div>	Monday	ˈməndā	<div class="definitions"><div class="speechpart">Nom</div><div class="line_1">the day of the week before Tuesday and following Sunday.</div><div class="line_2">I saw him on Monday</div></div>	

As you can see, the words contained in YourLanguageWord are in French, when they are supposed to be in English. It seems to be that this is opposite of intended behavior. The field YourLanguageWord is supposed to be "The word you want to learn but in your mother tongue or in a known language."

Has anyone encountered this issue?

@deleuzei
Copy link
Author

deleuzei commented Jan 6, 2022

It also makes the error of generating the pronunciation for the word in English.

@Otter-man
Copy link
Contributor

Otter-man commented Jan 6, 2022

@deleuzei hi!
This is intended behavior!
I assumed people would use the autogenerate functions like me - they will make a list of words in their target language (the language they study) and translate them to their mother tongue.
So original in the settings for autogenerated cards is actually supposed to be words you want to learn in other languages, and translation - is translation in your language, hence YourLanguageWord column.

It didn't occur to me that others might want to create cards mother tongue -> target language and that's why columns might be confusing in this case.

However, this shouldn't be a problem. Despite the confusion in column names, if you generate cards using this TSV file as a source file - it will generate two cards for each row - a card for one language and a reverse one for another. So you still can use it to study languages.

I'll keep it in mind when I'll be working on this module in the future.

It also makes the error of generating the pronunciation for the word in English.

Well, this is also coming from the fact that it expects English to be your target language

@deleuzei
Copy link
Author

deleuzei commented Jan 6, 2022

Thanks for the quick reply, I was just going to post that it kinda works given that there is a reverse card generated.

I think it is a common use case. Say you wanted to build up your knowledge in a specialized domain. I would be much easier to write down the all words you know in that domain in your native tongue at once, instead of going through a text and adding them one by one. That way you could prepare for the text beforehand, only later on adding specialized translations that google translate might have missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants