Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Events Horizontal Scrolling On Android #12728

Closed
JamieB-gu opened this issue Oct 31, 2024 · 3 comments · Fixed by guardian/bridget#172 · May be fixed by #12836
Closed

Key Events Horizontal Scrolling On Android #12728

JamieB-gu opened this issue Oct 31, 2024 · 3 comments · Fixed by guardian/bridget#172 · May be fixed by #12836
Assignees
@marjisound
Milestone
Decommission Temp...

Comments

@JamieB-gu
Copy link
Contributor

There is a bug on Android that means it's not possible to scroll horizontally through the key events at the top of liveblogs and deadblogs. This does not affect vertical scrolling through the rest of the article.

The options for fixing this are as follows:

  1. Fix the horizontal scrolling issue, which would require investigation by an Android developer.
  2. On Android only we could either truncate key events to only the first couple that are visible, or hide the key events section entirely. This is not a long term fix, but rather a temporary one until we can do 1).
  3. Redesign the key events section to use buttons to navigate rather than relying on a horizontally scrolling area. This will require discussion with Design.

Image
@JamieB-gu JamieB-gu added this to the Decommission Templates milestone Oct 31, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Nov 1, 2024
@JamieB-gu JamieB-gu moved this from Triage to This Sprint in WebX Team Nov 1, 2024
@JamieB-gu
Copy link
Contributor Author

JamieB-gu commented Nov 7, 2024 •
edited
Loading

We could consider adding a method to Bridget to deactivate Android scrolling behaviour whenever someone attempts to horizontal scroll on certain elements in an article. There was a similar method available in the templates: https://github.com/guardian/mobile-apps-article-templates/blob/ae6d5dcb28ed5f6eecb4d91fe5375b03ac4a6bd6/ArticleTemplates/assets/js/bootstraps/audio.js#L90-L110

Android are going to investigate whether this would work on their side, and we're going to investigate how and when we would call this method on our side.

@worldofpablo
Copy link

From memory, some other horizontal-scroll element encountering issues on Android on DCAR:

We should retest these if making a fix on the Android end of things for Key Events.

@marjisound marjisound self-assigned this Nov 12, 2024
This was linked to pull requests Nov 19, 2024
Add Service Interaction and disableArticleSwipe function guardian/bridget#172
Merged
add touch start and youch end events for key events carousel #12836
Draft
@marjisound
Copy link
Contributor

We're currently waiting for the Bridget PR guardian/bridget#172 to be merged so we can update DCR PR #12836 with the new Bridget version and start using the function. @arelra and I are also discussing the Bridget naming for the new service and function with the Android developers.

@github-project-automation github-project-automation bot moved this from In Progress to Done in WebX Team Nov 25, 2024
@marjisound marjisound reopened this Nov 25, 2024
@github-project-automation github-project-automation bot moved this from Done to Triage in WebX Team Nov 25, 2024
@marjisound marjisound moved this from Triage to In Progress in WebX Team Nov 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in WebX Team Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marjisound marjisound

Labels
None yet
Projects
WebX Team
Status: Done
Milestone
Decommission Templates
3 participants
@marjisound @JamieB-gu @worldofpablo