-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control of working directory by RunPMFECommand.sh #20
Comments
@ceheitsch The default run yields: $ ./RunPMFECommand.sh pmfe-tests
>> [PMFE-WRAPPER-SCRIPT] Changing current working directory to "/projects/rna/PMFEUpdated-2020.09.10-MDS-mschmidt34/GTDMMBSoftware2020/pmfe" ... Whereas, we can change the default working directory for the script to whatever by running: $ export PMFE_DATA_PATH="."
$ ./RunPMFECommand.sh pmfe
>> [PMFE-WRAPPER-SCRIPT] Changing current working directory to "/projects/rna/PMFEUpdated-2020.09.10-MDS-mschmidt34" ...
>> [PMFE-WRAPPER-SCRIPT] ERROR: Invalid PMFE utility binary argument type specified!
>> [PMFE-WRAPPER-SCRIPT] SCRIPT USAGE: ./RunPMFECommand.sh <pmfe-sage|pmfe-findmfe|pmfe-parametrizer|pmfe-scorer|pmfe-subopt|pmfe-tests||make-pmfe-source> [OPT-ARGS ...]
>> [PMFE-WRAPPER-SCRIPT] RECOGNIZED ENV SETTINGS (run `export VARNAME="value"` to set these options):
>> [PMFE-WRAPPER-SCRIPT] -> $PMFE_DATA_PATH: Sets the default runtime files path directory
>> [PMFE-WRAPPER-SCRIPT] (defaults to "/projects/rna/PMFEUpdated-2020.09.10-MDS-mschmidt34/GTDMMBSoftware2020/pmfe" if unset)
>> [PMFE-WRAPPER-SCRIPT] -> $PMFE_DEBUG: Specifies whether to run the selected binary with gdb to view extra logs
>> [PMFE-WRAPPER-SCRIPT] (set to "1" or "true" to enable) Does this address your question? |
@maxieds Since the wrapper script is not commented, it's not possible to know what all it's doing. In particular, the current script seems to be conflating things which need to be done only when the code is recompiled (e.g. running the tests, and possibly others) with what needs to be done only to run the code. |
@ceheitsch Nonetheless, I will look at CMake as an option to keep the compilation process error free for longer in the future. |
With respect to issue #5 (now closed), the point was made that:
However, it's far from clear why pmfe-tests needed to run every time the code is invoked. As it currently stands, it seems like it would be much better to have two separate wrapper scripts.
The first would be run only when the code is first installed locally or after updates to the code base. While the script would still need to be commented (see issue #7), a higher level of technical expertise on the user would be expected, since she is either attempting a local installation and/or has made updates to the code.
In contrast, the second script just include the commands needed to run already compiled code. It should be as simple as possible and would need to be more extensively commented.
The text was updated successfully, but these errors were encountered: