Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_cookie_store called without save_cookie_store won't persist to disk #1

Open
nicholaswild opened this issue Feb 22, 2013 · 1 comment

Comments

@nicholaswild
Copy link

I believe with HTTPClient calling set_cookie_store without calling save_cookie_store won't persist the store to disk. You also don't need to cal set_cookie_store at all if you just want to treat the cookies as volatile. Perhaps this was just in preparation for supporting more options in this area.

Great work!

@gstark
Copy link
Owner

gstark commented Feb 22, 2013

Yes, I was experimenting with the cookie store but I wasn't sure how to make it work. I think the API should work to try to use any existing cookie and if it fails to authenticate to re-login and obtain new session cookies.

If you are interested, please send a pull request with tests and I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants