Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Support prettier v3.0.0 #157

Open
alexasselin008 opened this issue Oct 24, 2023 · 1 comment
Open

[chore] Support prettier v3.0.0 #157

alexasselin008 opened this issue Oct 24, 2023 · 1 comment

Comments

@alexasselin008
Copy link
Member

Currently, using stylelint-configs with prettier =>3.0.0 causes the following error:

TypeError: prettier.resolveConfig.sync is not a function

The error seems to be caused by stylelint-prettier. They don't seems to have updated their package to support prettier v3.0.0 yet.

In the meantime, products should stay on prettier v2.8.8

@fraincs
Copy link

fraincs commented Oct 31, 2023

prettier/stylelint-prettier#298 (comment) According to this comment they seems to have.

After some tests I have been able to use Prettier 3.0.0 with stylelint-configs.

Here's my package.json devDepencies:

"devDependencies": {
        "@hopper-ui/tokens": "workspace:*",
        "@storybook/addon-essentials": "7.5.1",
        "@storybook/addon-interactions": "7.5.1",
        "@storybook/addon-links": "7.5.1",
        "@storybook/addon-mdx-gfm": "7.5.1",
        "@storybook/blocks": "7.5.1",
        "@storybook/react": "7.5.1",
        "@storybook/react-vite": "7.5.1",
        "@storybook/testing-library": "0.2.2",
        "@workleap/eslint-plugin": "3.0.0",
        "@workleap/stylelint-configs": "2.0.0",
        "@workleap/typescript-configs": "3.0.2",
        "eslint-plugin-storybook": "0.6.15",
        "prettier": "3.0.0",
        "prop-types": "15.8.1",
        "react": "18.2.0",
        "react-dom": "18.2.0",
        "stylelint": "15.11.0",
        "vite-plugin-turbosnap": "1.0.3"
    },

@patricklafrance patricklafrance changed the title [stylelint-configs] Support prettier v3.0.0 [chore] Support prettier v3.0.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants