From 8862f6e2dc11fba1cb3ea72b8fd3cf2a6a466b75 Mon Sep 17 00:00:00 2001 From: Alexandre Asselin Date: Thu, 12 Oct 2023 12:44:04 -0400 Subject: [PATCH] fix missed variables --- docs/features/style-props/StyleProps.stories.mdx | 2 +- .../components/src/badge/tests/chromatic/BadgeUtils.tsx | 4 ++-- packages/components/src/card/docs/Card.stories.mdx | 6 +++--- packages/components/src/dot/src/Dot.tsx | 3 +-- .../src/illustration/docs/Illustration.stories.mdx | 6 +++--- packages/components/src/modal/docs/Modal.stories.mdx | 2 +- packages/components/src/tile/docs/Tile.stories.mdx | 2 +- 7 files changed, 12 insertions(+), 13 deletions(-) diff --git a/docs/features/style-props/StyleProps.stories.mdx b/docs/features/style-props/StyleProps.stories.mdx index 741dff5f2..872603afc 100644 --- a/docs/features/style-props/StyleProps.stories.mdx +++ b/docs/features/style-props/StyleProps.stories.mdx @@ -53,7 +53,7 @@ Inspired by [Styled System](https://styled-system.com/), Orbiter's style props a To help achieve a consistent user interface, Orbiter style props are based on scales and values defined in a customizable [theme](?path=/docs/theming--page). -
+
Lost in space.
diff --git a/packages/components/src/badge/tests/chromatic/BadgeUtils.tsx b/packages/components/src/badge/tests/chromatic/BadgeUtils.tsx index 2d5137132..131df320c 100644 --- a/packages/components/src/badge/tests/chromatic/BadgeUtils.tsx +++ b/packages/components/src/badge/tests/chromatic/BadgeUtils.tsx @@ -9,7 +9,7 @@ export function SquareBadge({ children, ...rest }: BadgeUtilsProps) { return ( {children} -
+
); } @@ -21,7 +21,7 @@ export function CircleBadge({ children, ...rest }: BadgeUtilsProps) { overlap="circle" > {children} -
+
); } diff --git a/packages/components/src/card/docs/Card.stories.mdx b/packages/components/src/card/docs/Card.stories.mdx index 95a9d9b37..171bb3438 100644 --- a/packages/components/src/card/docs/Card.stories.mdx +++ b/packages/components/src/card/docs/Card.stories.mdx @@ -88,7 +88,7 @@ Or an [illustration](?path=/docs/illustration--horizontal): - + Planet over another one NASA Headquarters @@ -164,7 +164,7 @@ A card can render horizontally. - + Planet over another one NASA @@ -250,7 +250,7 @@ A card can take the width of its container. - + Planet over another one NASA diff --git a/packages/components/src/dot/src/Dot.tsx b/packages/components/src/dot/src/Dot.tsx index 89171d519..47ac7a4da 100644 --- a/packages/components/src/dot/src/Dot.tsx +++ b/packages/components/src/dot/src/Dot.tsx @@ -20,9 +20,8 @@ function useColor(color: string) { return color; } else if (color.startsWith("--")) { return `var(${color})`; + // This logic should be reworked and not imported as is in Hopper. Accessing the Mapping directly feels weird. } else if (!isNil(BackgroundColorMapping[color])) { - console.log("AA", color, BackgroundColorMapping[color]); - return BackgroundColorMapping[color]; } diff --git a/packages/components/src/illustration/docs/Illustration.stories.mdx b/packages/components/src/illustration/docs/Illustration.stories.mdx index a0bff1486..d940c8986 100644 --- a/packages/components/src/illustration/docs/Illustration.stories.mdx +++ b/packages/components/src/illustration/docs/Illustration.stories.mdx @@ -26,7 +26,7 @@ An illustration renders horizontally by default. - + @@ -38,7 +38,7 @@ An illustration can render vertically. - + Planet over another planet @@ -50,7 +50,7 @@ An illustration can have a `rounded` shape. - + Planet over another planet diff --git a/packages/components/src/modal/docs/Modal.stories.mdx b/packages/components/src/modal/docs/Modal.stories.mdx index d893ac0cb..59abc7365 100644 --- a/packages/components/src/modal/docs/Modal.stories.mdx +++ b/packages/components/src/modal/docs/Modal.stories.mdx @@ -97,7 +97,7 @@ Or an [illustration](?path=/docs/illustration--horizontal). Prefer 1:1 ratio for - + Planet Logo Cloud City diff --git a/packages/components/src/tile/docs/Tile.stories.mdx b/packages/components/src/tile/docs/Tile.stories.mdx index 94a2a9aac..2628adb22 100644 --- a/packages/components/src/tile/docs/Tile.stories.mdx +++ b/packages/components/src/tile/docs/Tile.stories.mdx @@ -69,7 +69,7 @@ Or an [illustration](?path=/docs/illustration--horizontal) with a background col - + Planet Buy a ticket